You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "Dave Brosius (JIRA)" <xa...@xml.apache.org> on 2006/03/20 01:25:00 UTC
[jira] Created: (XALANJ-2284) [PATCH] remove needless
synchronization
[PATCH] remove needless synchronization
---------------------------------------
Key: XALANJ-2284
URL: http://issues.apache.org/jira/browse/XALANJ-2284
Project: XalanJ2
Type: Improvement
Versions: Latest Development Code
Reporter: Dave Brosius
several places in the code use synchronized collections for local variables that never escape the method in which they are used. This is just a waste. This patch replaces these instances with non synchronized collections.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2284) [PATCH] remove needless
synchronization
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2284?page=comments#action_12446056 ]
Brian Minchau commented on XALANJ-2284:
---------------------------------------
The PMC has voted to drop support for JRE 1.1x, meaning that we now support 1.2 runtime and up.
Henry can now review the patch with that in mind.
> [PATCH] remove needless synchronization
> ---------------------------------------
>
> Key: XALANJ-2284
> URL: http://issues.apache.org/jira/browse/XALANJ-2284
> Project: XalanJ2
> Issue Type: Improvement
> Affects Versions: Latest Development Code
> Reporter: Dave Brosius
> Attachments: remove_needless_synchronization.diff
>
>
> several places in the code use synchronized collections for local variables that never escape the method in which they are used. This is just a waste. This patch replaces these instances with non synchronized collections.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Closed: (XALANJ-2284) [PATCH] remove needless
synchronization
Posted by "Dave Brosius (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANJ-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius closed XALANJ-2284.
--------------------------------
Patch applied correctly
> [PATCH] remove needless synchronization
> ---------------------------------------
>
> Key: XALANJ-2284
> URL: https://issues.apache.org/jira/browse/XALANJ-2284
> Project: XalanJ2
> Issue Type: Improvement
> Affects Versions: 2.7
> Reporter: Dave Brosius
> Assignee: Brian Minchau
> Fix For: 2.7.1
>
> Attachments: remove_needless_synchronization.diff
>
>
> several places in the code use synchronized collections for local variables that never escape the method in which they are used. This is just a waste. This patch replaces these instances with non synchronized collections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Resolved: (XALANJ-2284) [PATCH] remove needless
synchronization
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2284?page=all ]
Brian Minchau resolved XALANJ-2284.
-----------------------------------
Fix Version/s: Latest Development Code
Resolution: Fixed
The patch is now applied to the latest development code and resolved.
> [PATCH] remove needless synchronization
> ---------------------------------------
>
> Key: XALANJ-2284
> URL: http://issues.apache.org/jira/browse/XALANJ-2284
> Project: XalanJ2
> Issue Type: Improvement
> Affects Versions: Latest Development Code
> Reporter: Dave Brosius
> Assigned To: Brian Minchau
> Fix For: Latest Development Code
>
> Attachments: remove_needless_synchronization.diff
>
>
> several places in the code use synchronized collections for local variables that never escape the method in which they are used. This is just a waste. This patch replaces these instances with non synchronized collections.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2284) [PATCH] remove needless
synchronization
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2284?page=comments#action_12446099 ]
Brian Minchau commented on XALANJ-2284:
---------------------------------------
I have reviewed and tested the patch, and I approve it.
> [PATCH] remove needless synchronization
> ---------------------------------------
>
> Key: XALANJ-2284
> URL: http://issues.apache.org/jira/browse/XALANJ-2284
> Project: XalanJ2
> Issue Type: Improvement
> Affects Versions: Latest Development Code
> Reporter: Dave Brosius
> Assigned To: Brian Minchau
> Attachments: remove_needless_synchronization.diff
>
>
> several places in the code use synchronized collections for local variables that never escape the method in which they are used. This is just a waste. This patch replaces these instances with non synchronized collections.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Assigned: (XALANJ-2284) [PATCH] remove needless
synchronization
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2284?page=all ]
Brian Minchau reassigned XALANJ-2284:
-------------------------------------
Assignee: Henry Zongaro
Assigning to Henry Z. to review/apply the patch.
> [PATCH] remove needless synchronization
> ---------------------------------------
>
> Key: XALANJ-2284
> URL: http://issues.apache.org/jira/browse/XALANJ-2284
> Project: XalanJ2
> Issue Type: Improvement
> Affects Versions: Latest Development Code
> Reporter: Dave Brosius
> Assigned To: Henry Zongaro
> Attachments: remove_needless_synchronization.diff
>
>
> several places in the code use synchronized collections for local variables that never escape the method in which they are used. This is just a waste. This patch replaces these instances with non synchronized collections.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2284) [PATCH] remove needless
synchronization
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2284?page=comments#action_12442808 ]
Brian Minchau commented on XALANJ-2284:
---------------------------------------
I'll wait for Henry's comments on this patch.
His preliminary communication is that this patch is OK,
but it imples that we drop runtime support for 1.1.x and move
to 1.2 and up. Waiting for consensus from users and from
the PMC on moving to 1.2
> [PATCH] remove needless synchronization
> ---------------------------------------
>
> Key: XALANJ-2284
> URL: http://issues.apache.org/jira/browse/XALANJ-2284
> Project: XalanJ2
> Issue Type: Improvement
> Affects Versions: Latest Development Code
> Reporter: Dave Brosius
> Attachments: remove_needless_synchronization.diff
>
>
> several places in the code use synchronized collections for local variables that never escape the method in which they are used. This is just a waste. This patch replaces these instances with non synchronized collections.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2284) [PATCH] remove needless
synchronization
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2284?page=comments#action_12373169 ]
Brian Minchau commented on XALANJ-2284:
---------------------------------------
Comments from Xalan-J triage on April 4, 2006:
> Henry Z. agreed to review the patch.
> [PATCH] remove needless synchronization
> ---------------------------------------
>
> Key: XALANJ-2284
> URL: http://issues.apache.org/jira/browse/XALANJ-2284
> Project: XalanJ2
> Type: Improvement
> Versions: Latest Development Code
> Reporter: Dave Brosius
> Attachments: remove_needless_synchronization.diff
>
> several places in the code use synchronized collections for local variables that never escape the method in which they are used. This is just a waste. This patch replaces these instances with non synchronized collections.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Assigned: (XALANJ-2284) [PATCH] remove needless
synchronization
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2284?page=all ]
Brian Minchau reassigned XALANJ-2284:
-------------------------------------
Assignee: Brian Minchau (was: Henry Zongaro)
> [PATCH] remove needless synchronization
> ---------------------------------------
>
> Key: XALANJ-2284
> URL: http://issues.apache.org/jira/browse/XALANJ-2284
> Project: XalanJ2
> Issue Type: Improvement
> Affects Versions: Latest Development Code
> Reporter: Dave Brosius
> Assigned To: Brian Minchau
> Attachments: remove_needless_synchronization.diff
>
>
> several places in the code use synchronized collections for local variables that never escape the method in which they are used. This is just a waste. This patch replaces these instances with non synchronized collections.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org