You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by Ankush Mishra <an...@gmail.com> on 2018/10/28 18:53:31 UTC
Completion of testing of CalDAV module upgrade
Hello Maxim,
I wanted to inform that the upgrade is officially complete, and has been
verified for any bugs and those have been fixed, although, I have run
multiple rounds of testing, I will probably do a test run, once the code is
merged into the master and available on the demo server / somewhere,
because I can't test *master* , have ensured it working for the *4.0.x *branch
though.
There's also, a couple of things to note, the other things I mentioned
which were out of scope from the upgrade are currently a WIP, and will be
ready in short order.
I also wanted to ask, for the Background syncing on the page, should I add
another thread which handles all of sync requests through the use of a
BlockingQueue. I am not sure of how useful this will be unless the
front-end thread gets blocked for too long, which is a scenario I am yet to
face.
Regards
Ankush
Re: Completion of testing of CalDAV module upgrade
Posted by Ankush Mishra <an...@gmail.com>.
Great, thanks for the update. I'll do it in a while.
Thanks
Ankush
On Mon, Oct 29, 2018, 17:51 Maxim Solodovnik <so...@gmail.com> wrote:
> Yep, we have full integration with github
>
> On Mon, 29 Oct 2018 at 19:20, Ankush Mishra <an...@gmail.com>
> wrote:
>
>> Awesome, thanks! I'll check those out.
>>
>> Regarding the PR, where do you want me to do it? GitHub?
>>
>> Regards
>> Ankush
>>
>> On Mon, Oct 29, 2018, 07:55 Maxim Solodovnik <so...@gmail.com>
>> wrote:
>>
>>> Sound like a time for PR :)
>>>
>>> In case you have long running process you can use
>>> 1) indicating button(behavior):
>>> https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/dashboard/admin/AdminWidgetView.java#L40
>>> 2) separate thread with progress:
>>> https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/install/InstallWizard.java#L712
>>> 3) separate thread:
>>> https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/record/VideoInfo.java#L76
>>>
>>> :)
>>>
>>> On Mon, 29 Oct 2018 at 01:54, Ankush Mishra <an...@gmail.com>
>>> wrote:
>>>
>>>> Hello Maxim,
>>>>
>>>> I wanted to inform that the upgrade is officially complete, and has
>>>> been verified for any bugs and those have been fixed, although, I have run
>>>> multiple rounds of testing, I will probably do a test run, once the code is
>>>> merged into the master and available on the demo server / somewhere,
>>>> because I can't test *master* , have ensured it working for the *4.0.x
>>>> *branch though.
>>>>
>>>> There's also, a couple of things to note, the other things I mentioned
>>>> which were out of scope from the upgrade are currently a WIP, and will be
>>>> ready in short order.
>>>>
>>>> I also wanted to ask, for the Background syncing on the page, should I
>>>> add another thread which handles all of sync requests through the use of a
>>>> BlockingQueue. I am not sure of how useful this will be unless the
>>>> front-end thread gets blocked for too long, which is a scenario I am yet to
>>>> face.
>>>>
>>>> Regards
>>>> Ankush
>>>>
>>>
>>>
>>> --
>>> WBR
>>> Maxim aka solomax
>>>
>>
>
> --
> WBR
> Maxim aka solomax
>
Re: Completion of testing of CalDAV module upgrade
Posted by Maxim Solodovnik <so...@gmail.com>.
Yep, we have full integration with github
On Mon, 29 Oct 2018 at 19:20, Ankush Mishra <an...@gmail.com> wrote:
> Awesome, thanks! I'll check those out.
>
> Regarding the PR, where do you want me to do it? GitHub?
>
> Regards
> Ankush
>
> On Mon, Oct 29, 2018, 07:55 Maxim Solodovnik <so...@gmail.com> wrote:
>
>> Sound like a time for PR :)
>>
>> In case you have long running process you can use
>> 1) indicating button(behavior):
>> https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/dashboard/admin/AdminWidgetView.java#L40
>> 2) separate thread with progress:
>> https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/install/InstallWizard.java#L712
>> 3) separate thread:
>> https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/record/VideoInfo.java#L76
>>
>> :)
>>
>> On Mon, 29 Oct 2018 at 01:54, Ankush Mishra <an...@gmail.com>
>> wrote:
>>
>>> Hello Maxim,
>>>
>>> I wanted to inform that the upgrade is officially complete, and has been
>>> verified for any bugs and those have been fixed, although, I have run
>>> multiple rounds of testing, I will probably do a test run, once the code is
>>> merged into the master and available on the demo server / somewhere,
>>> because I can't test *master* , have ensured it working for the *4.0.x
>>> *branch though.
>>>
>>> There's also, a couple of things to note, the other things I mentioned
>>> which were out of scope from the upgrade are currently a WIP, and will be
>>> ready in short order.
>>>
>>> I also wanted to ask, for the Background syncing on the page, should I
>>> add another thread which handles all of sync requests through the use of a
>>> BlockingQueue. I am not sure of how useful this will be unless the
>>> front-end thread gets blocked for too long, which is a scenario I am yet to
>>> face.
>>>
>>> Regards
>>> Ankush
>>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>
--
WBR
Maxim aka solomax
Re: Completion of testing of CalDAV module upgrade
Posted by Ankush Mishra <an...@gmail.com>.
Awesome, thanks! I'll check those out.
Regarding the PR, where do you want me to do it? GitHub?
Regards
Ankush
On Mon, Oct 29, 2018, 07:55 Maxim Solodovnik <so...@gmail.com> wrote:
> Sound like a time for PR :)
>
> In case you have long running process you can use
> 1) indicating button(behavior):
> https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/dashboard/admin/AdminWidgetView.java#L40
> 2) separate thread with progress:
> https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/install/InstallWizard.java#L712
> 3) separate thread:
> https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/record/VideoInfo.java#L76
>
> :)
>
> On Mon, 29 Oct 2018 at 01:54, Ankush Mishra <an...@gmail.com>
> wrote:
>
>> Hello Maxim,
>>
>> I wanted to inform that the upgrade is officially complete, and has been
>> verified for any bugs and those have been fixed, although, I have run
>> multiple rounds of testing, I will probably do a test run, once the code is
>> merged into the master and available on the demo server / somewhere,
>> because I can't test *master* , have ensured it working for the *4.0.x *branch
>> though.
>>
>> There's also, a couple of things to note, the other things I mentioned
>> which were out of scope from the upgrade are currently a WIP, and will be
>> ready in short order.
>>
>> I also wanted to ask, for the Background syncing on the page, should I
>> add another thread which handles all of sync requests through the use of a
>> BlockingQueue. I am not sure of how useful this will be unless the
>> front-end thread gets blocked for too long, which is a scenario I am yet to
>> face.
>>
>> Regards
>> Ankush
>>
>
>
> --
> WBR
> Maxim aka solomax
>
Re: Completion of testing of CalDAV module upgrade
Posted by Maxim Solodovnik <so...@gmail.com>.
Sound like a time for PR :)
In case you have long running process you can use
1) indicating button(behavior):
https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/dashboard/admin/AdminWidgetView.java#L40
2) separate thread with progress:
https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/pages/install/InstallWizard.java#L712
3) separate thread:
https://github.com/apache/openmeetings/blob/master/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/record/VideoInfo.java#L76
:)
On Mon, 29 Oct 2018 at 01:54, Ankush Mishra <an...@gmail.com> wrote:
> Hello Maxim,
>
> I wanted to inform that the upgrade is officially complete, and has been
> verified for any bugs and those have been fixed, although, I have run
> multiple rounds of testing, I will probably do a test run, once the code is
> merged into the master and available on the demo server / somewhere,
> because I can't test *master* , have ensured it working for the *4.0.x *branch
> though.
>
> There's also, a couple of things to note, the other things I mentioned
> which were out of scope from the upgrade are currently a WIP, and will be
> ready in short order.
>
> I also wanted to ask, for the Background syncing on the page, should I add
> another thread which handles all of sync requests through the use of a
> BlockingQueue. I am not sure of how useful this will be unless the
> front-end thread gets blocked for too long, which is a scenario I am yet to
> face.
>
> Regards
> Ankush
>
--
WBR
Maxim aka solomax