[jira] Issue Comment Edited: (THRIFT-278) #validate exceptions should contain the offending value

["Kevin Clark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672987#action_12672987 ] 

kclark edited comment on THRIFT-278 at 2/12/09 7:23 AM:
-------------------------------------------------------------

Does this work? Maybe I'm reading it wrong, but:

{{+      indent(out) << "throw new TProtocolException(\"The field '" << field->get_name() << "' has been assigned the invalid value \" + " << field->get_name() << ");" << endl;}}

Looks like it just prints the field name as the value. Got a test?

      was (Author: kclark):
    Does this work? Maybe I'm reading it wrong, but:

{{monospaced}}+      indent(out) << "throw new TProtocolException(\"The field '" << field->get_name() << "' has been assigned the invalid value \" + " << field->get_name() << ");" << endl;{{monospaced}}

Looks like it just prints the field name as the value. Got a test?
  
> #validate exceptions should contain the offending value
> -------------------------------------------------------
>
>                 Key: THRIFT-278
>                 URL: https://issues.apache.org/jira/browse/THRIFT-278
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Ruby)
>            Reporter: Bryan Duxbury
>            Assignee: Piotr Kozikowski
>            Priority: Trivial
>             Fix For: 0.1
>
>         Attachments: thrift-278.patch
>
>
> If you have an enum field, and its value isn't in the VALID_VALUES of your enum, the exception thrown says that it's not found, but it doesn't say what the value is. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.