[GitHub] [dubbo-go] zouyx commented on a change in pull request #502: Feature/add comment for directory

[GitBox <gi...@apache.org>]

zouyx commented on a change in pull request #502:
URL: https://github.com/apache/dubbo-go/pull/502#discussion_r421900420



##########
File path: registry/directory/directory.go
##########
@@ -42,12 +42,12 @@ import (
 	"github.com/apache/dubbo-go/remoting"
 )
 
-// Options ...
+// Options Option is configuration related  struct of serviceTTL
 type Options struct {

Review comment:
       what abount change to `Option`?

##########
File path: registry/directory/directory.go
##########
@@ -42,12 +42,12 @@ import (
 	"github.com/apache/dubbo-go/remoting"
 )
 
-// Options ...
+// Options Option is configuration related  struct of serviceTTL
 type Options struct {
 	serviceTTL time.Duration
 }
 
-// Option ...
+// Option function of handling Options
 type Option func(*Options)

Review comment:
       what abount change to `OptionHandler` ?

##########
File path: registry/directory/directory.go
##########
@@ -90,18 +90,19 @@ func NewRegistryDirectory(url *common.URL, registry registry.Registry, opts ...O
 	return dir, nil
 }
 
-//subscribe from registry
+// Subscribe subscribe from registry

Review comment:
       ```suggestion
   // Subscribe from registry
   ```

##########
File path: registry/directory/directory.go
##########
@@ -256,7 +257,8 @@ func (dir *registryDirectory) List(invocation protocol.Invocation) []protocol.In
 	return routerChain.Route(invokers, dir.cacheOriginUrl, invocation)
 }
 
-func (dir *registryDirectory) IsAvailable() bool {
+// IsAvailable  whether the directory is available
+func (dir *registryDirectory) IsAvailableAvailable() bool {

Review comment:
       why `IsAvailableAvailable`.........




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org