You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/14 06:14:48 UTC

[GitHub] [pinot] snleee commented on a diff in pull request #9398: Reduce the log in tests

snleee commented on code in PR #9398:
URL: https://github.com/apache/pinot/pull/9398#discussion_r970354181


##########
pinot-broker/src/test/resources/log4j2.xml:
##########
@@ -22,14 +22,15 @@
 <Configuration>
   <Appenders>
     <Console name="console" target="SYSTEM_OUT">
-      <PatternLayout>
-        <pattern>%d{HH:mm:ss.SSS} %c{1} - %m%n</pattern>
-      </PatternLayout>
+      <PatternLayout pattern="%d{HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n"/>

Review Comment:
   Do we have any kind of job that parses from the log outputs? (e.g. compatibility test)
   
   I think that changing the pattern for test logs should be fine as long as we don't read anywhere in our testing jobs on Github action. But, we should be careful if it will change the production log pattern.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org