You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/01/19 09:33:44 UTC
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request
#4021: For #4005, fix none sharding strategy can't be config in spring-boot
KomachiSion opened a new pull request #4021: For #4005, fix none sharding strategy can't be config in spring-boot
URL: https://github.com/apache/incubator-shardingsphere/pull/4021
For #4005.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4021: For #4005, fix none sharding strategy can't be config in spring-boot
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4021: For #4005, fix none sharding strategy can't be config in spring-boot
URL: https://github.com/apache/incubator-shardingsphere/pull/4021#issuecomment-575988257
## Pull Request Test Coverage Report for [Build 1424](https://coveralls.io/builds/28195863)
* **2** of **3** **(66.67%)** changed or added relevant lines in **1** file are covered.
* **100** unchanged lines in **3** files lost coverage.
* Overall coverage increased (+**1.3%**) to **66.792%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-spring/sharding-spring-boot-util/src/main/java/org/apache/shardingsphere/spring/boot/converter/StringToNoneShardingStrategyConfigurationConverter.java](https://coveralls.io/builds/28195863/source?filename=sharding-spring%2Fsharding-spring-boot-util%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspring%2Fboot%2Fconverter%2FStringToNoneShardingStrategyConfigurationConverter.java#L30) | 2 | 3 | 66.67%
<!-- | **Total:** | **2** | **3** | **66.67%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/InsertStatement.java](https://coveralls.io/builds/28195863/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FInsertStatement.java#L72) | 1 | 96.97% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/insert/InsertColumnsExtractor.java](https://coveralls.io/builds/28195863/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Finsert%2FInsertColumnsExtractor.java#L48) | 8 | 10.53% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28195863/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L82) | 91 | 0% |
<!-- | **Total:** | **100** | | -->
| Totals | [](https://coveralls.io/builds/28195863) |
| :-- | --: |
| Change from base [Build 704](https://coveralls.io/builds/28194121): | 1.3% |
| Covered Lines: | 10815 |
| Relevant Lines: | 16192 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4021: For
#4005, fix none sharding strategy can't be config in spring-boot
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4021: For #4005, fix none sharding strategy can't be config in spring-boot
URL: https://github.com/apache/incubator-shardingsphere/pull/4021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4021: For
#4005, fix none sharding strategy can't be config in spring-boot
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4021: For #4005, fix none sharding strategy can't be config in spring-boot
URL: https://github.com/apache/incubator-shardingsphere/pull/4021#issuecomment-575988257
## Pull Request Test Coverage Report for [Build 1417](https://coveralls.io/builds/28194924)
* **2** of **3** **(66.67%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.0002%**) to **65.522%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-spring/sharding-spring-boot-util/src/main/java/org/apache/shardingsphere/spring/boot/converter/StringToNoneShardingStrategyConfigurationConverter.java](https://coveralls.io/builds/28194924/source?filename=sharding-spring%2Fsharding-spring-boot-util%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspring%2Fboot%2Fconverter%2FStringToNoneShardingStrategyConfigurationConverter.java#L30) | 2 | 3 | 66.67%
<!-- | **Total:** | **2** | **3** | **66.67%** | -->
| Totals | [](https://coveralls.io/builds/28194924) |
| :-- | --: |
| Change from base [Build 704](https://coveralls.io/builds/28194121): | 0.0002% |
| Covered Lines: | 10815 |
| Relevant Lines: | 16506 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services