[GitHub] [hive] odraese commented on a change in pull request #698: HIVE-21912: Implement DisablingDaemonStatisticsHandler

[GitBox <gi...@apache.org>]

odraese commented on a change in pull request #698: HIVE-21912: Implement DisablingDaemonStatisticsHandler
URL: https://github.com/apache/hive/pull/698#discussion_r300020689
 
 

 ##########
 File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
 ##########
 @@ -4358,6 +4358,40 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
       "The listener which is called when new Llap Daemon statistics is received on AM side.\n" +
       "The listener should implement the " +
       "org.apache.hadoop.hive.llap.tezplugins.metrics.LlapMetricsListener interface."),
+    LLAP_TASK_SCHEDULER_BLACKLISTING_METRICS_LISTENER_MIN_SERVED_TASKS(
+      "hive.llap.task.scheduler.blacklisting.metrics.listener.min.served.tasks", 2000,
 
 Review comment:
   Just as a general comment/observation:
   I have the feeling that our parm names are getting longer and longer, telling complete stories. You essentially can only copy/paste them into config files - there is no way that you remember these. We should try to keep these shorter!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org