You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "TezQA (JIRA)" <ji...@apache.org> on 2015/07/08 20:03:05 UTC

[jira] [Commented] (TEZ-2608) UnorderedPartitionedKVWriter should override write(Object key, Iterable values)
    [ https://issues.apache.org/jira/browse/TEZ-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619069#comment-14619069 ] 

TezQA commented on TEZ-2608:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12744262/TEZ-2608.001.patch
  against master revision cb59851.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/891//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/891//console

This message is automatically generated.

> UnorderedPartitionedKVWriter should override write(Object key, Iterable<Object> values) 
> ----------------------------------------------------------------------------------------
>
>                 Key: TEZ-2608
>                 URL: https://issues.apache.org/jira/browse/TEZ-2608
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Tsuyoshi Ozawa
>            Assignee: Tsuyoshi Ozawa
>         Attachments: TEZ-2608.001.patch
>
>
> From BaseUnorderedPartitionedKVWriter:
> {code}
>   @Override
>   public void write(Object key, Iterable<Object> values) throws IOException {
>     //TODO: UnorderedPartitionedKVWriter should override this method later.
>     Iterator<Object> it = values.iterator();
>     while(it.hasNext()) {
>       write(key, it.next());
>     }
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)