[jira] [Comment Edited] (OFBIZ-11021) The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841277#comment-16841277 ] 

Jacques Le Roux edited comment on OFBIZ-11021 at 5/16/19 12:49 PM:
-------------------------------------------------------------------

Sure [~jacques.le.roux],

RequirementMethodEnumId should be decided in the order of property set at ProductStore -> Facility -> Product for each order item which was not working if the non-drop shippable product(s) is added after the drop shippable product(s).

*Original Flow:* requirementMethodEnumId was initialized outside the loop and once it is initialized with Product level information it never gets re-initialized if Product is non-drop shippable.

I have updated the code to use the storeRequirementMethodEnumId variable for store level information which is defined outside the loop and this will be used to initialize requirementMethodEnumId for each order item and then product level information can override it. That means for each product *ProductStore -> Facility -> Product* this rule will work properly.

Hope It is more clear now. Thanks!


was (Author: pawan.verma):
Sure [~jacques.le.roux],

RequirementMethodEnumId should be decided in the order of property set at ProductStore -> Facility -> Product for each order item which was not working if the non-drop shippable product(s) is added after the drop shippable product(s).

*Original Flow:* requirementMethodEnumId was initialized outside the loop and once it is initialized with Product level information it never gets re-initialized if Product is non-drop shippable.

I have updated the code to use the storeRequirementMethodEnumId variable for store level information which is defined outside the loop and this will be used to initialize requirementMethodEnumId for each order item and then product level information can override it. That means for each product *ProductStore -> Facility -> Product* this rule will work properly.

 

Hope It is more clear now. Thanks!

 

> The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-11021
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11021
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Trunk, Release Branch 18.12
>            Reporter: Pawan Verma
>            Assignee: Suraj Khurana
>            Priority: Major
>         Attachments: OFBIZ-11021.patch
>
>
> The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart.
>   
>  Suppose we have two items in the cart:
>  # The first item is drop-shippable.
>  # The second item is not drop-shippable.
> For the first item, the implementation works fine.
>  For the second item, this is not working correctly.
>   
>  For drop shipment process, cart method 'createDropShipGroups' decides RequirementMethodEnumId in the order of property set at ProductStore -> ProductFacility -> Product which work fine in case of all drop-ship products and if the drop-ship product(s) is added last in the cart.
>   
>  The issue I found is that if a combination of a dropship and non-drop ship products are added into the cart and the non-drop shippable product(s) is added after the drop shippable product(s) then the non-drop-shippable products also considered as drop-shippable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)