You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/03/22 13:14:04 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #40518: [SPARK-42889][CONNECT][PYTHON][FOLLOWUP] Move `StorageLevel` into a separate file to avoid potential file recursively imports

HyukjinKwon commented on code in PR #40518:
URL: https://github.com/apache/spark/pull/40518#discussion_r1144792924


##########
connector/connect/common/src/main/protobuf/spark/connect/storage_level.proto:
##########
@@ -0,0 +1,37 @@
+/*

Review Comment:
   Should we rename this to something else at a high level? e.g., common.proto or utils.proto. Otherwise, LGTM from my end.
   
   cc @hvanhovell @grundprinzip @ueshin 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org