You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/19 21:48:45 UTC

[GitHub] [pulsar] rdhabalia opened a new issue #9644: Project-10: Replace local ZooKeeper and cache access from PulsarService and replace with Metadata-store API

rdhabalia opened a new issue #9644:
URL: https://github.com/apache/pulsar/issues/9644


   ### Goal
   PulsarService initializes `Local-ZooKeeper` and that is used by multiple components across pulsar-services. Remove local-zk access from dependent component and eventually remove local-zk initialization from the PulsarService.
   
   ### Reference
   **Component**: Pulsar-Service
   **Class-reference**: "- [PulsarServie:: localZkCacheService](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java#L168), [PulsarServie:: localZooKeeperConnectionProvider](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java#L173)
   **Affeceted Modules**: LoadManager: ModularLoadManagerImpl, NamespaceService, OwnershipCache, BookkeeperSchemaStorage
   
   
   ### Notes
   1. [PulsarServie:: localZkCacheService](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java#L168), [PulsarServie:: localZooKeeperConnectionProvider](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java#L173) initializes local zk and that is being used by multiple places eg: LoadManager: ModularLoadManagerImpl, NamespaceService, OwnershipCache, BookkeeperSchemaStorage
   2. Replace localZK access with Metadata-store resources in those places
   3. Remove localZK reference from the PulsarService


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli commented on issue #9644: Project-10: Replace local ZooKeeper and cache access from PulsarService and replace with Metadata-store API

Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #9644:
URL: https://github.com/apache/pulsar/issues/9644#issuecomment-783379335


   @rdhabalia  @merlimat 
   I am taking a look to `ModularLoadManagerImpl`, field `brokerDataCache`
   
   I cannot find a good replacement for `ZooKeeperDataCache`
   
   https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java#L123
   
   Also I see that `MetadataCacheImpl` is not able to set a listener on updates, and in fact it is not setting any watch on the cached zookeeper subtree.
   
   Am I looking to the wrong place ? or is support still missing ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli commented on issue #9644: Project-10: Replace local ZooKeeper and cache access from PulsarService and replace with Metadata-store API

Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #9644:
URL: https://github.com/apache/pulsar/issues/9644#issuecomment-783613368


   Okay. No problem from my side.
   Please assign me any ticket from this project that is still not started.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] merlimat closed issue #9644: Project-10: Replace local ZooKeeper and cache access from PulsarService and replace with Metadata-store API

Posted by GitBox <gi...@apache.org>.
merlimat closed issue #9644:
URL: https://github.com/apache/pulsar/issues/9644


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli commented on issue #9644: Project-10: Replace local ZooKeeper and cache access from PulsarService and replace with Metadata-store API

Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #9644:
URL: https://github.com/apache/pulsar/issues/9644#issuecomment-783217646


   I am picking this up, @rdhabalia please assign to me


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] rdhabalia commented on issue #9644: Project-10: Replace local ZooKeeper and cache access from PulsarService and replace with Metadata-store API

Posted by GitBox <gi...@apache.org>.
rdhabalia commented on issue #9644:
URL: https://github.com/apache/pulsar/issues/9644#issuecomment-783787221


   @eolivelli would like to take #9645 ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] merlimat commented on issue #9644: Project-10: Replace local ZooKeeper and cache access from PulsarService and replace with Metadata-store API

Posted by GitBox <gi...@apache.org>.
merlimat commented on issue #9644:
URL: https://github.com/apache/pulsar/issues/9644#issuecomment-783523989


   @eolivelli I actually had this already almost done locally. I just need to get one other PR in first (the locks reacquiring after the session gets re-established).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli commented on issue #9644: Project-10: Replace local ZooKeeper and cache access from PulsarService and replace with Metadata-store API

Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #9644:
URL: https://github.com/apache/pulsar/issues/9644#issuecomment-783932787


   @rdhabalia sure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org