[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6722: Fix inserting into a table with non-nullable columns

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6722:
URL: https://github.com/apache/arrow-datafusion/pull/6722#discussion_r1235660278


##########
datafusion/core/src/datasource/mod.rs:
##########
@@ -199,3 +200,24 @@ fn get_col_stats(
         })
         .collect()
 }
+
+fn schema_eq_ignore_nullable(

Review Comment:
   I could have sworn this function already existed (basically to compare two schemas ignoring nullabulity) but I could not find it
   
   This is the closest I found: https://docs.rs/datafusion-common/26.0.0/datafusion_common/struct.DFSchema.html#method.equivalent_names_and_types but it is not quite the same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org