[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once…

[GitBox <gi...@apache.org>]

terrymanu commented on a change in pull request #4826: issue-4785: Check uniformed with all actual tables' meta data in once…
URL: https://github.com/apache/incubator-shardingsphere/pull/4826#discussion_r394260250
 
 

 ##########
 File path: sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/metadata/ShardingMetaDataLoader.java
 ##########
 @@ -103,17 +104,25 @@ private SchemaMetaData loadDefaultSchemaMetaData() throws SQLException {
         return actualDefaultDataSourceName.isPresent()
                 ? SchemaMetaDataLoader.load(dataSourceMap.get(actualDefaultDataSourceName.get()), maxConnectionsSizePerQuery) : new SchemaMetaData(Collections.emptyMap());
     }
-    
-    // TODO check all meta data in once
+
     private void checkUniformed(final String logicTableName, final Map<String, TableMetaData> actualTableMetaDataMap) {
         ShardingTableMetaDataDecorator decorator = new ShardingTableMetaDataDecorator();
         TableMetaData sample = decorator.decorate(actualTableMetaDataMap.values().iterator().next(), logicTableName, shardingRule);
+        List<String[]> errorMetaDataList = new LinkedList<>();
 
 Review comment:
   The design `List<String[]>` is not clear, could you consider about define an object to process it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services