You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/18 07:02:16 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request #13389: Deprecate apachepulsar/pulsar-grafana docker image
michaeljmarshall opened a new pull request #13389:
URL: https://github.com/apache/pulsar/pull/13389
### Motivation
Clean up our `docker` directory. We currently produce a very outdated `pulsar-grafana` docker image with each release. The primary reason we're producing this image is to package grafana dashboards. Grafana allows easy import through the UI, or if you're running on Kubernetes, you can provide the dashboards as config maps. Given how old these files are, it looks like the dashboards do not receive much attention.
### Modifications
* Move the grafana dashboards to a top level directory. (We could also remove them completely if we don't intend to maintain them.)
* Remove the mvn build script for the `pulsar-grafana` docker image.
### Verifying this change
Once tests pass, I'll send a note to the dev mailing list to make sure we get the right visibility on this change before merging it.
### Does this pull request potentially affect one of the following parts:
This PR deprecates our custom grafana docker image.
### Documentation
- [x] `doc`
I updated the latest docs with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #13389: Deprecate apachepulsar/pulsar-grafana docker image
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #13389:
URL: https://github.com/apache/pulsar/pull/13389#issuecomment-997564912
Can you start a mail thread in the pulsar maillist so that users and devs can get updates about this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #13389: Deprecate apachepulsar/pulsar-grafana docker image
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #13389:
URL: https://github.com/apache/pulsar/pull/13389#issuecomment-998087356
> Once tests pass, I'll send a note to the dev mailing list to make sure we get the right visibility on this change before merging it.
@freeznet - yes, my plan is to send a note once I get tests passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13389: Deprecate apachepulsar/pulsar-grafana docker image
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13389:
URL: https://github.com/apache/pulsar/pull/13389#discussion_r772044196
##########
File path: site2/docs/deploy-monitoring.md
##########
@@ -108,15 +108,7 @@ The per-topic dashboard instructions are available at [Pulsar manager](administr
You can use grafana to create dashboard driven by the data that is stored in Prometheus.
-When you deploy Pulsar on Kubernetes, a `pulsar-grafana` Docker image is enabled by default. You can use the docker image with the principal dashboards.
-
-Enter the command below to use the dashboard manually:
-
-```shell
-docker run -p3000:3000 \
- -e PROMETHEUS_URL=http://$PROMETHEUS_HOST:9090/ \
- apachepulsar/pulsar-grafana:latest
-```
+When you deploy Pulsar on Kubernetes with the Pulsar Helm Chart, a `pulsar-grafana` Docker image is enabled by default. You can use the docker image with the principal dashboards.
Review comment:
@freeznet can you review this PR from the technical perspective?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #13389: Deprecate apachepulsar/pulsar-grafana docker image
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #13389:
URL: https://github.com/apache/pulsar/pull/13389#issuecomment-997158239
Note that we currently use this docker image in a dcos example here https://github.com/apache/pulsar/blob/c5d7a84c8e5c27e48022df8c7082496840cd3be9/deployment/dcos/PulsarGroups.json#L310
I think it might be worth removing the DCOS example all together, since it hasn't been updated in 4 years.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #13389: Deprecate apachepulsar/pulsar-grafana docker image
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #13389:
URL: https://github.com/apache/pulsar/pull/13389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org