You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2026/07/01 02:34:23 UTC
[PR] feat(validator): add project-template drift check [magpie]
justinmclean opened a new pull request, #663:
URL: https://github.com/apache/magpie/pull/663
## Summary
Add validate_project_template_drift (check #15) to
tools/skill-and-tool-validator to mechanically compare
projects/_template/ with projects/non-asf-example/ for structural
drift, closing the Known gap in specs/project-agnosticism.md.
Three SOFT advisory checks under the new template-drift category:
1. README file-list coherence: every file linked in the ## Files
section of non-asf-example/README.md must exist on disk.
2. Undocumented files: every .md file in non-asf-example/ (other
than README.md) must be mentioned somewhere in its README.
3. Shared-file h2 alignment: for each .md file present in both
profiles, h2 section headings are compared. project.md and
README.md are excluded since they differ intentionally by
organization profile (org-inherited blocks, narrative structure).
22 new tests in TestProjectTemplateDrift cover all checks, the
live-repo clean-state assertion, DocToc-stripping, exclusion of
parent-traversal and external URLs, and the project.md/README.md
exemptions. The live tree produces zero template-drift violations.
Updates specs/project-agnosticism.md Known gaps to document the
new check and its scope.
Generated-by: Claude (Opus 4.7)
## Type of change
- [ ] Skill change (`.claude/skills/<name>/`) — eval fixtures updated below
- [] Tool / bridge contract (`tools/<system>/*.md`)
- [X] Python package (`tools/*/` with `pyproject.toml`)
- [ ] Groovy reference impl
- [ ] Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
- [ ] Documentation (`docs/`, `README.md`, `CONTRIBUTING.md`)
- [ ] Project template (`projects/_template/`)
- [ ] CI / dev loop (`prek`, workflows, validators)
- [ ] Other:
## Test plan
- [X] `prek run --all-files` passes
- [X] For Python packages touched: `uv run pytest` / `ruff check` / `mypy` passes
- [ ] For Groovy bridges touched: command-line invocation tested end-to-end
- [ ] For skill changes: eval suite passes for the affected skill
(`PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/`)
- [ ] For skill *behaviour* changes: a new or updated eval fixture is included in this PR
(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
- [X] Other: manually tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(validator): add project-template drift check [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #663:
URL: https://github.com/apache/magpie/pull/663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org