You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by keypointt <gi...@git.apache.org> on 2015/10/04 19:07:13 UTC
[GitHub] spark pull request: [SPARK-10669] [Docs] Link to each language's A...
GitHub user keypointt opened a pull request:
https://github.com/apache/spark/pull/8974
[SPARK-10669] [Docs] Link to each language's API in codetabs in ML docs: spark.mllib
my first PR, please let me know if more work is needed. Thanks a lot!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keypointt/spark SPARK-10669
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8974.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8974
----
commit f8289891d5b32fffdc6a4ce077d8d206e015119f
Author: Xin Ren <ia...@126.com>
Date: 2015-10-02T07:00:36Z
[SPARK-10669] test modify
commit 67c67158c93a4a8c5a963ecf821f5e85e1228bf3
Author: Xin Ren <ia...@126.com>
Date: 2015-10-04T16:54:35Z
[SPARK-10669] Link to each language API in codetabs in spark mllib docs
commit 31960f6790a75fd037ffd879a8d17e546c5fa6fa
Author: Xin Ren <ia...@126.com>
Date: 2015-10-04T16:59:56Z
[SPARK-10669] minor correction
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10669] [Docs] Link to each language's A...
Posted by keypointt <gi...@git.apache.org>.
Github user keypointt commented on the pull request:
https://github.com/apache/spark/pull/8974#issuecomment-145368459
@srowen After checking the ticket you mentioned, now I know what is exactly expected. I'm closing this one and continue work on SPARK-10669. Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10669] [Docs] Link to each language's A...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8974#issuecomment-145367212
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10669] [Docs] Link to each language's A...
Posted by keypointt <gi...@git.apache.org>.
Github user keypointt closed the pull request at:
https://github.com/apache/spark/pull/8974
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10669] [Docs] Link to each language's A...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8974#issuecomment-145367909
@keypointt I don't this is what the JIRA was getting at. See https://issues.apache.org/jira/browse/SPARK-10670 and https://github.com/apache/spark/pull/8901 instead. I think you'd want to start over and close this one though some of the extra links are nice here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org