You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "erenavsarogullari (via GitHub)" <gi...@apache.org> on 2024/03/24 04:24:35 UTC

[PR] refactor: Extract `array_resize` and `cardinality` functions from `functions-array` subcrate' s `kernels` and `udf` containers [arrow-datafusion]

erenavsarogullari opened a new pull request, #9766:
URL: https://github.com/apache/arrow-datafusion/pull/9766

   ## Which issue does this PR close?
   Closes #9765.
   
   ## What changes are included in this PR?
   This PR aims to do following refactoring:
   1- Extracts `array_resize` and `cardinality` functions from `functions-array` subcrate' s `kernels` and `udf` containers,
   2- Being added `make_scalar_function` support to `ArrayResize` and `Cardinality` invoke functions,
   3- Being added minor refactoring such as cleaning-up redundant package definitions etc.
   
   ## Are these changes tested?
   Yes, all `array.slt` based `array_resize` and `cardinality` functions tests are passed.
   
   ## Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: Extract `array_resize` and `cardinality` functions from `functions-array` subcrate' s `kernels` and `udf` containers [arrow-datafusion]

Posted by "erenavsarogullari (via GitHub)" <gi...@apache.org>.
erenavsarogullari commented on PR #9766:
URL: https://github.com/apache/arrow-datafusion/pull/9766#issuecomment-2016695701

   @jayzhan211 Thanks for the review. I will also submit #9767 after then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: Extract `array_resize` and `cardinality` functions from `functions-array` subcrate' s `kernels` and `udf` containers [arrow-datafusion]

Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 merged PR #9766:
URL: https://github.com/apache/arrow-datafusion/pull/9766


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org