You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/09 17:46:37 UTC

[GitHub] [incubator-tvm] trevor-m opened a new pull request #4668: Fix Base64OutStream portability issue

trevor-m opened a new pull request #4668: Fix Base64OutStream portability issue
URL: https://github.com/apache/incubator-tvm/pull/4668
 
 
   Fixes #4660 
   On ARM, char is unsigned by default while on x86 it is signed by default. On ARM, this causes the logic in `Base64OutStream::Finish` to incorrectly add a char with value of 255 to the end of every b64 string. Fix is to use int for the endchar. Alternatively we could explicitly use `signed char`.
   https://www.linuxtopia.org/online_books/an_introduction_to_gcc/gccintro_71.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #4668: Fix Base64OutStream portability issue

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4668: Fix Base64OutStream portability issue
URL: https://github.com/apache/incubator-tvm/pull/4668#issuecomment-572707715
 
 
   Thanks @trevor-m 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen merged pull request #4668: Fix Base64OutStream portability issue

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4668: Fix Base64OutStream portability issue
URL: https://github.com/apache/incubator-tvm/pull/4668
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services