[jira] [Commented] (HADOOP-7698) jsvc target fails on x86_64

["Harsh J (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461332#comment-13461332 ] 

Harsh J commented on HADOOP-7698:
---------------------------------

Daryn's patch seems to work pretty well.

OSX:

{code}
➜  hadoop-1 git:(branch-1) ✗ gst          
# On branch branch-1
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#	modified:   build.xml
#
no changes added to commit (use "git add" and/or "git commit -a")
➜  hadoop-1 git:(branch-1) ✗ ant jsvc     
Buildfile: /Users/harshchouraria/Work/code/apache/hadoop-1/build.xml

jsvc:
      [get] Getting: http://archive.apache.org/dist/commons/daemon/binaries/1.0.2/darwin/commons-daemon-1.0.2-bin-darwin-universal.tar.gz
      [get] To: /Users/harshchouraria/Work/code/apache/hadoop-1/build/jsvc.x86_64/jsvc.x86_64.tar.gz
    [untar] Expanding: /Users/harshchouraria/Work/code/apache/hadoop-1/build/jsvc.x86_64/jsvc.x86_64.tar.gz into /Users/harshchouraria/Work/code/apache/hadoop-1/build/jsvc.x86_64

BUILD SUCCESSFUL
Total time: 4 seconds
{code}

Linux x64:

{code}
➜  hadoop git:(branch-1) ✗ gst
# On branch branch-1
# Changed but not updated:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#	modified:   build.xml
#
no changes added to commit (use "git add" and/or "git commit -a")
➜  hadoop git:(branch-1) ✗ ant jsvc
Buildfile: build.xml

jsvc:
      [get] Getting: http://archive.apache.org/dist/commons/daemon/binaries/1.0.2/linux/commons-daemon-1.0.2-bin-linux-x86_64.tar.gz
      [get] To: /home/harsh/hadoop/build/jsvc.amd64/jsvc.amd64.tar.gz
    [untar] Expanding: /home/harsh/hadoop/build/jsvc.amd64/jsvc.amd64.tar.gz into /home/harsh/hadoop/build/jsvc.amd64

BUILD SUCCESSFUL
Total time: 0 seconds
{code}

+1 hence, committing.
                
> jsvc target fails on x86_64
> ---------------------------
>
>                 Key: HADOOP-7698
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7698
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.20.205.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Critical
>         Attachments: HADOOP-7698-1.patch, HADOOP-7968.patch
>
>
> Recent changes to the build.xml determine with jsvc file to download based on the os.arch.  It maps various arch values to i386 or x86_64. However, it notably doesn't consider x86_64 to be x86_64.  The result is this the download fails because {{os-arch}} doesn't expand.
> {code}
> build.xml:2626: Can't get http://archive.apache.org/dist/commons/daemon/binaries/1.0.2/linux/commons-daemon-1.0.2-bin-linux-${os-arch}.tar.gz
> {code}
> This breaks {{test-patch}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira