You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by milooy <gi...@git.apache.org> on 2018/05/31 12:28:48 UTC
[GitHub] zeppelin pull request #2994: [ZEPPELIN-3285] Refine the style of Notebook ti...
GitHub user milooy opened a pull request:
https://github.com/apache/zeppelin/pull/2994
[ZEPPELIN-3285] Refine the style of Notebook title
### What is this PR for?
Refine the style of Notebook title
(Ellipsis by character, 100% width under medium width browser, align delete button)
(Before)
(After)
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3285
### How should this be tested?
**1. Run webapp**
```vi
cd zeppelin-web
yarn run dev
```
**2. Check the title have ellipsis by character, not looks cut.**
(before / after)
**3. Check 'delete button' is aligned**
(before / after)
**4. Check the title with is 100% under the window width 650px**
(before / after)
* First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milooy/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2994.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2994
----
commit 8b7d1b8db6c6677de37ea4e79372118f2774a90c
Author: Jay Jin <ja...@...>
Date: 2018-05-29T10:32:31Z
ZEPPELIN-3285 Align delete button in action bar
commit a4418341f652cebc54fd9518f15fc07626a62ce4
Author: Jay Jin <ja...@...>
Date: 2018-05-31T12:08:43Z
ZEPPELIN-3285 Delete left margin of title, ellipsis by word, RWD
----
---
[GitHub] zeppelin issue #2994: [ZEPPELIN-3285] Refine the style of Notebook title
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2994
will merge this if there are no more discussions
---
[GitHub] zeppelin issue #2994: [ZEPPELIN-3285] Refine the style of Notebook title
Posted by Savalek <gi...@git.apache.org>.
Github user Savalek commented on the issue:
https://github.com/apache/zeppelin/pull/2994
@milooy, thanks. Could you take into account the mistakes corrected by this PR [2983](https://github.com/apache/zeppelin/pull/2983)
---
[GitHub] zeppelin issue #2994: [ZEPPELIN-3285] Refine the style of Notebook title
Posted by milooy <gi...@git.apache.org>.
Github user milooy commented on the issue:
https://github.com/apache/zeppelin/pull/2994
@r-kamath
Resolved with rebase :) thank you.
@Savalek
Checked the visibility of title in report and juno theme with unhovered / hovered state.
Thank you for the referencing the PR. It was helpful 👍
---
[GitHub] zeppelin pull request #2994: [ZEPPELIN-3285] Refine the style of Notebook ti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2994
---
[GitHub] zeppelin issue #2994: [ZEPPELIN-3285] Refine the style of Notebook title
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2994
@milooy Thanks for the contribution. Please resolve the conflicts.
---
[GitHub] zeppelin issue #2994: [ZEPPELIN-3285] Refine the style of Notebook title
Posted by milooy <gi...@git.apache.org>.
Github user milooy commented on the issue:
https://github.com/apache/zeppelin/pull/2994
@r-kamath @Leemoonsoo
What do I need to do more to merge the PR?
---