[GitHub] [flink] zentol commented on issue #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions

[GitBox <gi...@apache.org>]

zentol commented on issue #11184: [FLINK-16232][hive][build] Remove log4j2 exclusions
URL: https://github.com/apache/flink/pull/11184#issuecomment-591398061
 
 
   The log4j2 versions are defined in the dependency management in the root pom and are consistent across the entire project.
   
   Because of that the exclusion is just noise.
   
   I also prefer the dependency graph of transitive dependencies to stick close to the original. Right now we claim that hive doesn't require log4j, but this only works since Flink _by chance_ uses log4j as well.
   If we were to switch to a different logging backend the hive tests would suddenly fail with ClassNotFoundExceptions since neither log4j1 or 2 are on the classpath, but the dependency graph did not indicate that it actually needed them.
   Issues like this should be apparent in the build system imo, and should not require running anything.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services