You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/03/27 09:05:40 UTC

[GitHub] [calcite-avatica] asolimando commented on pull request #138: [CALCITE-2489] Order of fields in JavaTypeFactoryImpl#createStructTyp…

asolimando commented on pull request #138:
URL: https://github.com/apache/calcite-avatica/pull/138#issuecomment-808696554


   > @asolimando Regarding the change that is neccessary to do in Calcite for the tests to pass do we need to wait for [CALCITE-2489](https://issues.apache.org/jira/browse/CALCITE-2489) or it can be done independently?
   
   The fix does not depend on CALCITE-2489 and can be applied independently, it just boils down to replacing `clazz` with `null` at this line in Calcite: 
   https://github.com/apache/calcite/blob/4bc916619fd286b2c0cc4d5c653c96a68801d74e/core/src/main/java/org/apache/calcite/jdbc/CalciteMetaImpl.java#L200
   
   I can file a JIRA ticket in Calcite for that and prepare a PR so we are ready for Avatica 1.18.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org