You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/22 21:58:22 UTC

[GitHub] conglei opened a new pull request #4866: [axis formatting] Override the valueformat to be percentage when contribution is selected

conglei opened a new pull request #4866: [axis formatting] Override the valueformat to be percentage when contribution is selected
URL: https://github.com/apache/incubator-superset/pull/4866
 
 
   Currently, the default value format when `contribution` is selected is not intuitive. (e.g., 0.5 -> 500m). In this PR, the value format will be overridden by `.1%`.
   
   The reason here why I don' want want to change and save the current formatting to percentage are 1) the user selected format will be preserved when users uncheck `contribution`. 2) It seems in all the cases when user check `contribution`, percentage format for the value is the best approach. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services