You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by "Nicolas BONAMY (JIRA)" <ji...@apache.org> on 2009/11/23 15:07:39 UTC
[jira] Created: (ROL-1848) Bad url when add an image to a weblog
Bad url when add an image to a weblog
-------------------------------------
Key: ROL-1848
URL: https://issues.apache.org/jira/browse/ROL-1848
Project: Roller
Issue Type: Bug
Components: Weblog Editor
Affects Versions: 5.0
Environment: Ubuntu 2.6.28-16 64bits
Reporter: Nicolas BONAMY
Assignee: Roller Unassigned
When we add an image to a weblog (in edition mode), the mediaLink url doesn't appear.
The issue is to modify MediaFileImageChooser.jsp by this :
<s:iterator id="mediaFile" value="childFiles">
<li class="align-images"
onmouseover="highlight(this, true)" onmouseout="highlight(this, false)">
<s:url id="mediaFileURL" includeContext="false"
value="%{#mediaFile.permalink}"></s:url>
<s:url id="mediaFileThumbnailURL"
value="%{#mediaFile.thumbnailURL}"></s:url>
<div class="mediaObject"
onclick="onSelectImage('<s:property value="#mediaFile.name"/>','<s:property value="%{mediaFileURL}" />')" >
<s:if test="#mediaFile.imageFile">
<img border="0" src='<s:property value="%{mediaFileThumbnailURL}" />'
width='<s:property value="#mediaFile.thumbnailWidth"/>'
height='<s:property value="#mediaFile.thumbnailHeight"/>' />
</s:if>
</div>
<div class="mediaObjectInfo">
<label>
<str:truncateNicely upper="50">
<s:property value="#mediaFile.name" />
</str:truncateNicely>
</label>
</div>
</li>
</s:iterator>
</ul>
</div>
<div style="clear:left;"></div>
</s:form>
</s:if>
<script type="text/javascript">
<!--
function onSelectImage(name, url) {
if(url.match("^" + url) == url) {
window.parent.onSelectImage(name, url);
} else {
window.parent.onSelectImage(name, '<s:property
value="absoluteSiteURL" />' + url);
}
}
-->
</script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ROL-1848) Bad url when add an image to a weblog
Posted by "Dave Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Johnson resolved ROL-1848.
-------------------------------
Resolution: Duplicate
dup of ROL-1851
> Bad url when add an image to a weblog
> -------------------------------------
>
> Key: ROL-1848
> URL: https://issues.apache.org/jira/browse/ROL-1848
> Project: Roller
> Issue Type: Bug
> Components: Weblog Editor
> Affects Versions: 5.0
> Environment: Ubuntu 2.6.28-16 64bits
> Reporter: Nicolas BONAMY
> Assignee: David Johnson
> Fix For: 5.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When we add an image to a weblog (in edition mode), the mediaLink url doesn't appear.
> The issue is to modify MediaFileImageChooser.jsp by this :
> <s:iterator id="mediaFile" value="childFiles">
> <li class="align-images"
> onmouseover="highlight(this, true)" onmouseout="highlight(this, false)">
> <s:url id="mediaFileURL" includeContext="false"
> value="%{#mediaFile.permalink}"></s:url>
> <s:url id="mediaFileThumbnailURL"
> value="%{#mediaFile.thumbnailURL}"></s:url>
> <div class="mediaObject"
> onclick="onSelectImage('<s:property value="#mediaFile.name"/>','<s:property value="%{mediaFileURL}" />')" >
> <s:if test="#mediaFile.imageFile">
> <img border="0" src='<s:property value="%{mediaFileThumbnailURL}" />'
> width='<s:property value="#mediaFile.thumbnailWidth"/>'
> height='<s:property value="#mediaFile.thumbnailHeight"/>' />
> </s:if>
> </div>
> <div class="mediaObjectInfo">
> <label>
> <str:truncateNicely upper="50">
> <s:property value="#mediaFile.name" />
> </str:truncateNicely>
> </label>
> </div>
> </li>
> </s:iterator>
> </ul>
> </div>
> <div style="clear:left;"></div>
> </s:form>
> </s:if>
> <script type="text/javascript">
> <!--
> function onSelectImage(name, url) {
> if(url.match("^" + url) == url) {
> window.parent.onSelectImage(name, url);
> } else {
> window.parent.onSelectImage(name, '<s:property
> value="absoluteSiteURL" />' + url);
> }
> }
> -->
> </script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ROL-1848) Bad url when add an image to a weblog
Posted by "David Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Johnson updated ROL-1848:
-------------------------------
Fix Version/s: 5.0
Assignee: David Johnson (was: Roller Unassigned)
> Bad url when add an image to a weblog
> -------------------------------------
>
> Key: ROL-1848
> URL: https://issues.apache.org/jira/browse/ROL-1848
> Project: Roller
> Issue Type: Bug
> Components: Weblog Editor
> Affects Versions: 5.0
> Environment: Ubuntu 2.6.28-16 64bits
> Reporter: Nicolas BONAMY
> Assignee: David Johnson
> Fix For: 5.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When we add an image to a weblog (in edition mode), the mediaLink url doesn't appear.
> The issue is to modify MediaFileImageChooser.jsp by this :
> <s:iterator id="mediaFile" value="childFiles">
> <li class="align-images"
> onmouseover="highlight(this, true)" onmouseout="highlight(this, false)">
> <s:url id="mediaFileURL" includeContext="false"
> value="%{#mediaFile.permalink}"></s:url>
> <s:url id="mediaFileThumbnailURL"
> value="%{#mediaFile.thumbnailURL}"></s:url>
> <div class="mediaObject"
> onclick="onSelectImage('<s:property value="#mediaFile.name"/>','<s:property value="%{mediaFileURL}" />')" >
> <s:if test="#mediaFile.imageFile">
> <img border="0" src='<s:property value="%{mediaFileThumbnailURL}" />'
> width='<s:property value="#mediaFile.thumbnailWidth"/>'
> height='<s:property value="#mediaFile.thumbnailHeight"/>' />
> </s:if>
> </div>
> <div class="mediaObjectInfo">
> <label>
> <str:truncateNicely upper="50">
> <s:property value="#mediaFile.name" />
> </str:truncateNicely>
> </label>
> </div>
> </li>
> </s:iterator>
> </ul>
> </div>
> <div style="clear:left;"></div>
> </s:form>
> </s:if>
> <script type="text/javascript">
> <!--
> function onSelectImage(name, url) {
> if(url.match("^" + url) == url) {
> window.parent.onSelectImage(name, url);
> } else {
> window.parent.onSelectImage(name, '<s:property
> value="absoluteSiteURL" />' + url);
> }
> }
> -->
> </script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ROL-1848) Bad url when add an image to a weblog
Posted by "Anil Gangolli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ROL-1848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806751#action_12806751 ]
Anil Gangolli commented on ROL-1848:
------------------------------------
This looks like a duplicate of ROL-1851, and I think the fix attached to ROL-1851 looks more appropriate. Still needs some additional review time.
> Bad url when add an image to a weblog
> -------------------------------------
>
> Key: ROL-1848
> URL: https://issues.apache.org/jira/browse/ROL-1848
> Project: Roller
> Issue Type: Bug
> Components: Weblog Editor
> Affects Versions: 5.0
> Environment: Ubuntu 2.6.28-16 64bits
> Reporter: Nicolas BONAMY
> Assignee: David Johnson
> Fix For: 5.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When we add an image to a weblog (in edition mode), the mediaLink url doesn't appear.
> The issue is to modify MediaFileImageChooser.jsp by this :
> <s:iterator id="mediaFile" value="childFiles">
> <li class="align-images"
> onmouseover="highlight(this, true)" onmouseout="highlight(this, false)">
> <s:url id="mediaFileURL" includeContext="false"
> value="%{#mediaFile.permalink}"></s:url>
> <s:url id="mediaFileThumbnailURL"
> value="%{#mediaFile.thumbnailURL}"></s:url>
> <div class="mediaObject"
> onclick="onSelectImage('<s:property value="#mediaFile.name"/>','<s:property value="%{mediaFileURL}" />')" >
> <s:if test="#mediaFile.imageFile">
> <img border="0" src='<s:property value="%{mediaFileThumbnailURL}" />'
> width='<s:property value="#mediaFile.thumbnailWidth"/>'
> height='<s:property value="#mediaFile.thumbnailHeight"/>' />
> </s:if>
> </div>
> <div class="mediaObjectInfo">
> <label>
> <str:truncateNicely upper="50">
> <s:property value="#mediaFile.name" />
> </str:truncateNicely>
> </label>
> </div>
> </li>
> </s:iterator>
> </ul>
> </div>
> <div style="clear:left;"></div>
> </s:form>
> </s:if>
> <script type="text/javascript">
> <!--
> function onSelectImage(name, url) {
> if(url.match("^" + url) == url) {
> window.parent.onSelectImage(name, url);
> } else {
> window.parent.onSelectImage(name, '<s:property
> value="absoluteSiteURL" />' + url);
> }
> }
> -->
> </script>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.