You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by re...@apache.org on 2019/05/29 11:41:48 UTC

svn commit: r1860330 - /jackrabbit/oak/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilderTest.java

Author: reschke
Date: Wed May 29 11:41:48 2019
New Revision: 1860330

URL: http://svn.apache.org/viewvc?rev=1860330&view=rev
Log:
OAK-8251: RDBBlobStore instantiated from ReadOnly DocumentNodeStore should never modify persistence - add ignored test

Modified:
    jackrabbit/oak/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilderTest.java

Modified: jackrabbit/oak/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilderTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilderTest.java?rev=1860330&r1=1860329&r2=1860330&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilderTest.java (original)
+++ jackrabbit/oak/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilderTest.java Wed May 29 11:41:48 2019
@@ -23,24 +23,37 @@ import java.util.UUID;
 import javax.sql.DataSource;
 
 import org.apache.jackrabbit.oak.plugins.document.DocumentStoreException;
+import org.junit.Ignore;
 import org.junit.Test;
 
 public class RDBDocumentNodeStoreBuilderTest {
 
     @Test
-    public void testReadOnly() throws Exception {
+    public void testReadOnlyDS() throws Exception {
         // see OAK-8214
 
         DataSource dataSource = RDBDataSourceFactory.forJdbcUrl("jdbc:h2:mem:" + UUID.randomUUID(), "", "");
-
-        RDBDocumentNodeStoreBuilder b = RDBDocumentNodeStoreBuilder.newRDBDocumentNodeStoreBuilder();
-        b.setRDBConnection(dataSource);
-        b.setReadOnlyMode();
+        RDBDocumentNodeStoreBuilder b = RDBDocumentNodeStoreBuilder.newRDBDocumentNodeStoreBuilder().setRDBConnection(dataSource).setReadOnlyMode();
 
         try {
             b.getDocumentStore();
             fail("should not get here");
         } catch (DocumentStoreException expected) {
         }
+    }
+
+    @Ignore("OAK-8251")
+    @Test
+    public void testReadOnlyBS() throws Exception {
+        // see OAK-8251
+
+        DataSource dataSource = RDBDataSourceFactory.forJdbcUrl("jdbc:h2:mem:" + UUID.randomUUID(), "", "");
+        RDBDocumentNodeStoreBuilder b = RDBDocumentNodeStoreBuilder.newRDBDocumentNodeStoreBuilder().setRDBConnection(dataSource).setReadOnlyMode();
+
+        try {
+            b.getBlobStore();
+            fail("should not get here");
+        } catch (DocumentStoreException expected) {
+        }
     }
 }