You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/13 07:45:03 UTC
[GitHub] [spark] sarutak opened a new pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
sarutak opened a new pull request #32147:
URL: https://github.com/apache/spark/pull/32147
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to enable the JSON datasources to write non-ascii characters as codepoints.
To enable/disable this feature, I introduce a new option `writeNonAsciiCharacterAsCodePoint` for JSON datasources.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
JSON specification allows codepoints as literal but Spark SQL's JSON datasources don't support the way to do it.
It's great if we can write non-ascii characters as codepoints, which is a platform neutral representation.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Users can write non-ascii characters as codepoints with JSON datasources.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-820148243
**[Test build #137386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137386/testReport)** for PR 32147 at commit [`2091c59`](https://github.com/apache/spark/commit/2091c5927eba2759c84c54f99859ed56352859d9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class VectorizedBLAS extends F2jBLAS `
* `trait AnalysisOnlyCommand extends Command `
* ` implicit class MetadataColumnHelper(attr: Attribute) `
* `case class WriteToDataSourceV2(`
* `case class WriteToMicroBatchDataSource(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-828094776
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138010/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-827944582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-818595793
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41867/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-818522141
**[Test build #137287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137287/testReport)** for PR 32147 at commit [`d0179c5`](https://github.com/apache/spark/commit/d0179c588531ea345e9514eb25458f76b803a720).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-821089777
**[Test build #137484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137484/testReport)** for PR 32147 at commit [`765d7ea`](https://github.com/apache/spark/commit/765d7eaaaee256177b5628f823b175b583ffff70).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-820014886
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41963/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #32147:
URL: https://github.com/apache/spark/pull/32147#discussion_r614730077
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
##########
@@ -2844,6 +2844,25 @@ abstract class JsonSuite
assert(readback.collect sameElements Array(Row(0), Row(1), Row(2)))
}
}
+
+ test("Write Non-ASCII character as codepoint") {
+ // scalastyle:off nonascii
+ withTempPath { path =>
+ val basePath = path.getCanonicalPath
+ Seq("a", "\n", "\u3042").toDF.write
+ .option("writeNonAsciiCharacterAsCodePoint", "true").json(s"$basePath")
+ val actualText = spark.read.text(s"$basePath")
+ .sort("value").map(_.getString(0)).collect().mkString
+ val expectedText = "{\"value\":\"\\n\"}{\"value\":\"\\u3042\"}{\"value\":\"a\"}"
+ assert(actualText === expectedText)
+
+ val actualJson = spark.read.json(s"$basePath")
+ .sort("value").map(_.getString(0)).collect().mkString
+ val expectedJson = "\na\u3042"
+ assert(actualJson === expectedJson)
+ }
+ // scalastyle:on nonascii
+ }
Review comment:
#32203 was merged and I've rebased to `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #32147:
URL: https://github.com/apache/spark/pull/32147#discussion_r614495771
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
##########
@@ -2844,6 +2844,25 @@ abstract class JsonSuite
assert(readback.collect sameElements Array(Row(0), Row(1), Row(2)))
}
}
+
+ test("Write Non-ASCII character as codepoint") {
Review comment:
I didn't add the JIRA ID because this is an improvement but I don't mind to add it.
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
##########
@@ -135,6 +135,9 @@ private[sql] class JSONOptions(
*/
val inferTimestamp: Boolean = parameters.get("inferTimestamp").map(_.toBoolean).getOrElse(false)
+ val writeNonAsciiCharacterAsCodePoint: Boolean =
Review comment:
O.K, I'll add description
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
##########
@@ -2844,6 +2844,25 @@ abstract class JsonSuite
assert(readback.collect sameElements Array(Row(0), Row(1), Row(2)))
}
}
+
+ test("Write Non-ASCII character as codepoint") {
+ // scalastyle:off nonascii
+ withTempPath { path =>
+ val basePath = path.getCanonicalPath
+ Seq("a", "\n", "\u3042").toDF.write
+ .option("writeNonAsciiCharacterAsCodePoint", "true").json(s"$basePath")
+ val actualText = spark.read.text(s"$basePath")
+ .sort("value").map(_.getString(0)).collect().mkString
+ val expectedText = "{\"value\":\"\\n\"}{\"value\":\"\\u3042\"}{\"value\":\"a\"}"
+ assert(actualText === expectedText)
+
+ val actualJson = spark.read.json(s"$basePath")
+ .sort("value").map(_.getString(0)).collect().mkString
+ val expectedJson = "\na\u3042"
+ assert(actualJson === expectedJson)
+ }
+ // scalastyle:on nonascii
+ }
Review comment:
O.K, I'll cover the case of `pretty=true`.
BTW, I've noticed another issue when writing the test case for `pretty=true` (#32203).
So, I'll fix that issue first.
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
##########
@@ -73,7 +73,12 @@ private[sql] class JacksonGenerator(
private val gen = {
val generator = new JsonFactory().createGenerator(writer).setRootValueSeparator(null)
- if (options.pretty) generator.useDefaultPrettyPrinter() else generator
+ val ppGenerator = if (options.pretty) generator.useDefaultPrettyPrinter() else generator
+ if (options.writeNonAsciiCharacterAsCodePoint) {
+ generator.setHighestNonEscapedChar(0x7F)
Review comment:
We can set both options. Thanks. I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-818739446
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137287/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-819957856
**[Test build #137386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137386/testReport)** for PR 32147 at commit [`2091c59`](https://github.com/apache/spark/commit/2091c5927eba2759c84c54f99859ed56352859d9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-820158713
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137386/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-829426335
BTW, sorry for being later, @sarutak .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32147:
URL: https://github.com/apache/spark/pull/32147#discussion_r613755701
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
##########
@@ -73,7 +73,12 @@ private[sql] class JacksonGenerator(
private val gen = {
val generator = new JsonFactory().createGenerator(writer).setRootValueSeparator(null)
- if (options.pretty) generator.useDefaultPrettyPrinter() else generator
+ val ppGenerator = if (options.pretty) generator.useDefaultPrettyPrinter() else generator
+ if (options.writeNonAsciiCharacterAsCodePoint) {
+ generator.setHighestNonEscapedChar(0x7F)
Review comment:
This code means that we cannot set both `options.pretty` and `options.writeNonAsciiCharacterAsCodePoint`. If this is true, shall we document it somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-818729864
**[Test build #137287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137287/testReport)** for PR 32147 at commit [`d0179c5`](https://github.com/apache/spark/commit/d0179c588531ea345e9514eb25458f76b803a720).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-824634581
@dongjoon-hyun Do you have any comment on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-822130888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-821089777
**[Test build #137484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137484/testReport)** for PR 32147 at commit [`765d7ea`](https://github.com/apache/spark/commit/765d7eaaaee256177b5628f823b175b583ffff70).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-818595793
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41867/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32147:
URL: https://github.com/apache/spark/pull/32147#discussion_r613755840
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
##########
@@ -2844,6 +2844,25 @@ abstract class JsonSuite
assert(readback.collect sameElements Array(Row(0), Row(1), Row(2)))
}
}
+
+ test("Write Non-ASCII character as codepoint") {
Review comment:
If you don't mind, shall we have a JIRA ID prefix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-827978226
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42529/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-821075342
**[Test build #755259205](https://github.com/sarutak/spark/actions/runs/755259205)** for PR 32147 at commit [`765d7ea`](https://github.com/sarutak/spark/commit/765d7eaaaee256177b5628f823b175b583ffff70).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-818593929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-821267170
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137484/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-829870878
@dongjoon-hyun
Please don't worry.
Sorry if you felt rushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-822221390
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137541/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-822131771
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42115/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-820158713
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137386/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-822117306
**[Test build #137541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137541/testReport)** for PR 32147 at commit [`aff4c36`](https://github.com/apache/spark/commit/aff4c361a8ba4b8aa3ada2b695bd1ca0f2c3bae1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #32147:
URL: https://github.com/apache/spark/pull/32147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-827978226
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42529/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-822221390
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137541/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-819951185
**[Test build #750332703](https://github.com/sarutak/spark/actions/runs/750332703)** for PR 32147 at commit [`2091c59`](https://github.com/sarutak/spark/commit/2091c5927eba2759c84c54f99859ed56352859d9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-818522141
**[Test build #137287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137287/testReport)** for PR 32147 at commit [`d0179c5`](https://github.com/apache/spark/commit/d0179c588531ea345e9514eb25458f76b803a720).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32147:
URL: https://github.com/apache/spark/pull/32147#discussion_r613752661
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
##########
@@ -135,6 +135,9 @@ private[sql] class JSONOptions(
*/
val inferTimestamp: Boolean = parameters.get("inferTimestamp").map(_.toBoolean).getOrElse(false)
+ val writeNonAsciiCharacterAsCodePoint: Boolean =
Review comment:
Shall we add some description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32147:
URL: https://github.com/apache/spark/pull/32147#discussion_r613756126
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
##########
@@ -2844,6 +2844,25 @@ abstract class JsonSuite
assert(readback.collect sameElements Array(Row(0), Row(1), Row(2)))
}
}
+
+ test("Write Non-ASCII character as codepoint") {
+ // scalastyle:off nonascii
+ withTempPath { path =>
+ val basePath = path.getCanonicalPath
+ Seq("a", "\n", "\u3042").toDF.write
+ .option("writeNonAsciiCharacterAsCodePoint", "true").json(s"$basePath")
+ val actualText = spark.read.text(s"$basePath")
+ .sort("value").map(_.getString(0)).collect().mkString
+ val expectedText = "{\"value\":\"\\n\"}{\"value\":\"\\u3042\"}{\"value\":\"a\"}"
+ assert(actualText === expectedText)
+
+ val actualJson = spark.read.json(s"$basePath")
+ .sort("value").map(_.getString(0)).collect().mkString
+ val expectedJson = "\na\u3042"
+ assert(actualJson === expectedJson)
+ }
+ // scalastyle:on nonascii
+ }
Review comment:
It would be great if we can have a test coverage for setting both pretty and non-ascii-as-codepoint at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-820012530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-827944582
**[Test build #138010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138010/testReport)** for PR 32147 at commit [`93efbb3`](https://github.com/apache/spark/commit/93efbb3c72edd58804d70d683de76d767eb8dc85).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-819957856
**[Test build #137386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137386/testReport)** for PR 32147 at commit [`2091c59`](https://github.com/apache/spark/commit/2091c5927eba2759c84c54f99859ed56352859d9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-828094776
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138010/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-822117306
**[Test build #137541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137541/testReport)** for PR 32147 at commit [`aff4c36`](https://github.com/apache/spark/commit/aff4c361a8ba4b8aa3ada2b695bd1ca0f2c3bae1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-822131771
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42115/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-821122747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-821122779
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42059/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-818739446
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137287/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-820014886
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41963/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-822219606
**[Test build #137541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137541/testReport)** for PR 32147 at commit [`aff4c36`](https://github.com/apache/spark/commit/aff4c361a8ba4b8aa3ada2b695bd1ca0f2c3bae1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-821242922
**[Test build #137484 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137484/testReport)** for PR 32147 at commit [`765d7ea`](https://github.com/apache/spark/commit/765d7eaaaee256177b5628f823b175b583ffff70).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class PandasOnSparkFrameMethods(object):`
* `class PandasOnSparkSeriesMethods(object):`
* `class PandasOnSparkPlotAccessor(PandasObject):`
* `class PandasOnSparkBarPlot(PandasBarPlot, TopNPlotBase):`
* `class PandasOnSparkBoxPlot(PandasBoxPlot, BoxPlotBase):`
* `class PandasOnSparkHistPlot(PandasHistPlot, HistogramPlotBase):`
* `class PandasOnSparkPiePlot(PandasPiePlot, TopNPlotBase):`
* `class PandasOnSparkAreaPlot(PandasAreaPlot, SampledPlotBase):`
* `class PandasOnSparkLinePlot(PandasLinePlot, SampledPlotBase):`
* `class PandasOnSparkBarhPlot(PandasBarhPlot, TopNPlotBase):`
* `class PandasOnSparkScatterPlot(PandasScatterPlot, TopNPlotBase):`
* `class PandasOnSparkKdePlot(PandasKdePlot, KdePlotBase):`
* `class PandasOnSparkUsageLogger(object):`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-821122779
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42059/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32147: [SPARK-35047][SQL] Allow Json datasources to write non-ascii characters as codepoints
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32147:
URL: https://github.com/apache/spark/pull/32147#issuecomment-828084981
**[Test build #138010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138010/testReport)** for PR 32147 at commit [`93efbb3`](https://github.com/apache/spark/commit/93efbb3c72edd58804d70d683de76d767eb8dc85).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org