You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/10 13:47:16 UTC
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #971: Keep password case-sensitive in kvrocks2redis
PragmaTwice commented on code in PR #971:
URL: https://github.com/apache/incubator-kvrocks/pull/971#discussion_r991307470
##########
tools/kvrocks2redis/config.cc:
##########
@@ -89,11 +92,11 @@ Status Config::parseConfigFromString(std::string input) {
kvrocks_host = args[1];
// In new versions, we don't use extra port to implement replication
kvrocks_port = std::stoi(args[2]);
- if (kvrocks_port <= 0 || kvrocks_port >= 65535) {
+ if (kvrocks_port <= 0 || kvrocks_port > 65535) {
Review Comment:
I can get the point, but I wonder if port `65535` is preserved for other usage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org