You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/10/23 20:31:38 UTC
[GitHub] trafficserver pull request #1134: TS-4997: Move C++ API to plugins.
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/1134
TS-4997: Move C++ API to plugins.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver TS-4997
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1134
----
commit b66e6994abadf1b305b4a56b3a48bfd2535d0bcf
Author: James Peach <jp...@apache.org>
Date: 2016-10-22T18:28:29Z
TS-4995: Consolidate C++ API example plugins.
Move all the C++ example plugins into the 'example' directory so
that there is only one place to look for plugin examples.
commit a0e9905f9674a5569a27cc6ba646999f4c0163bb
Author: James Peach <jp...@apache.org>
Date: 2016-10-23T20:29:41Z
TS-4997: Move C++ API to the plugins directory.
Although the C++ API is a dependency of some plugins, it is itself
a consumer of the TS plugin API, so the best place from a build
ordering perspective is the plugins directory.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1134
I'll make a new PR that moves it to ``lib/cppapi``. This isn't ideal, but it removes the unnecessary ``src`` directory and we can probably agree on it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1134: TS-4997: Move the C++ API to lib/cppapi.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1134
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1073/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1134
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1068/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1134
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1069/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1134
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/960/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1134
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/961/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1134: TS-4997: Move the C++ API to lib/cppapi.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1134
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/965/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1134
Hmmm, are we sure this makes sense? The CPP APIs aren't plugins, and we certainly don't put the TS API's into plugins. I could perhaps see this go into proxy somewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1134
I agree with Leif. Looking at the patch again I think it is good to move the plugins to example/, but not all cppapi under plugins/.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1134: TS-4997: Move C++ API to plugins.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1134
As I mentioned, from a build and dependencies point of view, ``cppapi`` is a plugin. It depends on the TS API layer and is constrained (currently) from using any internal APIs. So the build is basically the same as a plugin.
It certainly does not belong in `lib` because it is not an internal library and is a consumer of the low layers. ``plugins`` is not the ideal home, but it seems like the best option for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1134: TS-4997: Move the C++ API to lib/cppapi.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/1134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---