You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2016/04/01 00:41:26 UTC
Re: Review Request 45372: Skip flaky test test_health_checker_metrics
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45372/
-----------------------------------------------------------
(Updated March 31, 2016, 3:41 p.m.)
Review request for Aurora, John Sirois and Zameer Manji.
Summary (updated)
-----------------
Skip flaky test test_health_checker_metrics
Repository: aurora
Description (updated)
-------
This test has been known flaky for over a year, but has been particularly problematic lately. Skipping the test as there is no clear path to fixing it.
Diffs (updated)
-----
src/test/python/apache/aurora/executor/common/test_health_checker.py b0ce81a16e86fac65c1e2a92ca3a46dadb50e181
Diff: https://reviews.apache.org/r/45372/diff/
Testing
-------
None yet
Thanks,
Bill Farner
Re: Review Request 45372: Skip flaky test test_health_checker_metrics
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45372/#review127528
-----------------------------------------------------------
Ship it!
Master (11d5a72) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 7, 2016, 12:42 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45372/
> -----------------------------------------------------------
>
> (Updated April 7, 2016, 12:42 a.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This test has been known flaky for over a year, but has been particularly problematic lately. Skipping the test as there is no clear path to fixing it.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_health_checker.py b0ce81a16e86fac65c1e2a92ca3a46dadb50e181
>
> Diff: https://reviews.apache.org/r/45372/diff/
>
>
> Testing
> -------
>
> None yet
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45372: Skip flaky test test_health_checker_metrics
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45372/#review127525
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On April 6, 2016, 6:42 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45372/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 6:42 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This test has been known flaky for over a year, but has been particularly problematic lately. Skipping the test as there is no clear path to fixing it.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_health_checker.py b0ce81a16e86fac65c1e2a92ca3a46dadb50e181
>
> Diff: https://reviews.apache.org/r/45372/diff/
>
>
> Testing
> -------
>
> None yet
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45372: Skip flaky test test_health_checker_metrics
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45372/
-----------------------------------------------------------
(Updated April 6, 2016, 5:42 p.m.)
Review request for Aurora, John Sirois and Zameer Manji.
Changes
-------
add missing import
Repository: aurora
Description
-------
This test has been known flaky for over a year, but has been particularly problematic lately. Skipping the test as there is no clear path to fixing it.
Diffs (updated)
-----
src/test/python/apache/aurora/executor/common/test_health_checker.py b0ce81a16e86fac65c1e2a92ca3a46dadb50e181
Diff: https://reviews.apache.org/r/45372/diff/
Testing
-------
None yet
Thanks,
Bill Farner
Re: Review Request 45372: Skip flaky test test_health_checker_metrics
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45372/#review126620
-----------------------------------------------------------
Ship it!
Once you add `import pytest` at the top this should work fine.
- Zameer Manji
On March 31, 2016, 3:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45372/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 3:41 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This test has been known flaky for over a year, but has been particularly problematic lately. Skipping the test as there is no clear path to fixing it.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_health_checker.py b0ce81a16e86fac65c1e2a92ca3a46dadb50e181
>
> Diff: https://reviews.apache.org/r/45372/diff/
>
>
> Testing
> -------
>
> None yet
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45372: Skip flaky test test_health_checker_metrics
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45372/#review126489
-----------------------------------------------------------
Master (17ade11) is red with this patch.
./build-support/jenkins/build.sh
Executing tasks in goals: bootstrap -> imports -> unpack-jars -> deferred-sources -> jvm-platform-validate -> gen -> resolve -> compile -> resources -> test[0m
23:19:03 00:02 [bootstrap]
23:19:03 00:02 [jar-dependency-management]
23:19:03 00:02 [bootstrap-jvm-tools]
23:19:03 00:02 [imports]
23:19:03 00:02 [ivy-imports]
23:19:03 00:02 [unpack-jars]
23:19:03 00:02 [unpack-jars]
23:19:03 00:02 [deferred-sources]
23:19:03 00:02 [deferred-sources]
23:19:03 00:02 [jvm-platform-validate]
23:19:03 00:02 [jvm-platform-validate]
23:19:03 00:02 [gen]
23:19:03 00:02 [thrift]
23:19:03 00:02 [protoc]
23:19:03 00:02 [antlr]
23:19:03 00:02 [ragel]
23:19:03 00:02 [jaxb]
23:19:03 00:02 [wire]
23:19:04 00:03 [resolve]
23:19:04 00:03 [ivy]
23:19:04 00:03 [bootstrap-nailgun-server]
23:19:08 00:07 [compile]
23:19:08 00:07 [compile-jvm-prep-command]
23:19:08 00:07 [jvm_prep_command]
23:19:08 00:07 [compile-prep-command]
23:19:08 00:07 [python-eval]
23:19:08 00:07 [pythonstyle]
23:19:09 00:08 [cache] [32m
No cached artifacts for 42 targets.[0m[32m
Invalidated 42 targets.[0m
F821:ERROR src/test/python/apache/aurora/executor/common/test_health_checker.py:149 undefined name 'pytest'
| @pytest.mark.skipif('True', reason='Flaky test (AURORA-1182)')
FAILURE: Python Style issues found
23:20:31 01:30 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 31, 2016, 10:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45372/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 10:41 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This test has been known flaky for over a year, but has been particularly problematic lately. Skipping the test as there is no clear path to fixing it.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_health_checker.py b0ce81a16e86fac65c1e2a92ca3a46dadb50e181
>
> Diff: https://reviews.apache.org/r/45372/diff/
>
>
> Testing
> -------
>
> None yet
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45372: Skip flaky test test_health_checker_metrics
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45372/#review126485
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On March 31, 2016, 4:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45372/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 4:41 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This test has been known flaky for over a year, but has been particularly problematic lately. Skipping the test as there is no clear path to fixing it.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_health_checker.py b0ce81a16e86fac65c1e2a92ca3a46dadb50e181
>
> Diff: https://reviews.apache.org/r/45372/diff/
>
>
> Testing
> -------
>
> None yet
>
>
> Thanks,
>
> Bill Farner
>
>