You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2017/10/03 19:50:09 UTC

[Impala-ASF-CR] IMPALA-5174: Suppress kudu flags that aren't relevant to Impala

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8074 )

Change subject: IMPALA-5174: Suppress kudu flags that aren't relevant to Impala
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8074/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8074/1//COMMIT_MSG@12
PS1, Line 12:  #include-d in Impala code
Do we know why this is the case ? I don't see DECLARE_FLAG() in all header files.



-- 
To view, visit http://gerrit.cloudera.org:8080/8074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I499c903cde92595c4a02803ecbf98ac1d41517b4
Gerrit-Change-Number: 8074
Gerrit-PatchSet: 1
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Tue, 03 Oct 2017 19:50:09 +0000
Gerrit-HasComments: Yes