[GitHub] [iceberg] jackye1995 commented on a change in pull request #2965: Core: rename WRITE_NEW_DATA_LOCATION to WRITE_FOLDER_STORAGE_LOCATION

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #2965:
URL: https://github.com/apache/iceberg/pull/2965#discussion_r688657344



##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -142,6 +142,12 @@ private TableProperties() {
   // This only applies to files written after this property is set. Files previously written aren't
   // relocated to reflect this parameter.
   // If not set, defaults to a "data" folder underneath the root path of the table.
+  public static final String WRITE_FOLDER_STORAGE_LOCATION = "write.folder-storage.path";
+
+  /**
+   * @deprecated will be removed in 0.14.0, use {@link #WRITE_FOLDER_STORAGE_LOCATION} instead
+   */
+  @Deprecated

Review comment:
       I think migration is unnecessary. The actual value stored is always `write.folder-storage.path`, we are just changing the Java variable name. And as I noted, we will deprecate after 2 releases, so that people can have time to change their variable name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org