You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dharmesh Kakadia <dh...@gmail.com> on 2013/05/07 19:44:12 UTC
Suggestion needed for CLOUDSTACK-212
Hi,
I am trying to move java package structure from com.cloud to org.apache (
https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am thinking of
doing it the following way (Totally newbie), needed feedback on that.
1. grep "com.cloud" on the entire repo.
2. update all package declarations using eclipse.
3. Update scripts etc found in 1 manually.
Will it be a good way to do it ? Any better suggestion ?
Thanks,
Dharmesh
RE: Suggestion needed for CLOUDSTACK-212
Posted by Alex Huang <Al...@citrix.com>.
+1 to 4.3. 4.2 is too close to freeze date.
--Alex
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Wednesday, May 8, 2013 6:31 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Suggestion needed for CLOUDSTACK-212
>
> Dharmesh,
>
> I'd also suggest that you actually plan on submitting this after the 4.2 feature
> freeze, to be included in 4.3. This is the type of change that has bitten us
> with almost every release... and doing it close to the end of the merge
> window may not be a good idea. Our general preference is to do these types
> of changes in master right *after* the latest feature release has it's branch
> cut.
>
> -chip
>
> On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
> > ok. I will go with that.
> >
> > Thanks,
> > Dharmesh
> >
> > On Wed, May 8, 2013 at 1:08 AM, Chip Childers
> <ch...@sungard.com>wrote:
> >
> > > On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> > > > Hi,
> > > >
> > > > I am trying to move java package structure from com.cloud to
> > > > org.apache (
> > > > https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
> thinking of doing it the following way (Totally newbie), needed feedback on
> that.
> > > >
> > > > 1. grep "com.cloud" on the entire repo.
> > > > 2. update all package declarations using eclipse.
> > > > 3. Update scripts etc found in 1 manually.
> > > >
> > > > Will it be a good way to do it ? Any better suggestion ?
> > > >
> > > > Thanks,
> > > > Dharmesh
> > >
> > > That seems like a reasonable approach. We will probably want to
> > > create a branch when you submit a patch for this, and apply it
> > > there... just to spend some time ensuring that the changes work.
> > >
> > > -chip
> > >
Re: Suggestion needed for CLOUDSTACK-212
Posted by Dharmesh Kakadia <dh...@gmail.com>.
I have finished the refactoring (ran into eclipse refactoring bugs). I am
now trying to test. But I realized that it will be good to have tool/script
that does most of this refactoring rather than using eclipse. Anyone knows
any such tool/script ? Otherwise I plan to make one.
Thanks,
Dharmesh
On Wed, May 8, 2013 at 9:08 PM, Dharmesh Kakadia <dh...@gmail.com>wrote:
> I have started refactoring !! I am planning to finish refactoring by
> tomorrow. I will then need help and guidance in doing testing,branching
> etc. Let's try this out !!
>
> Thanks,
> Dharmesh
>
>
> On Wed, May 8, 2013 at 7:20 PM, Sebastien Goasguen <ru...@gmail.com>wrote:
>
>>
>> On May 8, 2013, at 9:30 AM, Chip Childers <ch...@sungard.com>
>> wrote:
>>
>> > Dharmesh,
>> >
>> > I'd also suggest that you actually plan on submitting this after the 4.2
>> > feature freeze, to be included in 4.3. This is the type of change that
>> > has bitten us with almost every release... and doing it close to the
>> > end of the merge window may not be a good idea. Our general preference
>> > is to do these types of changes in master right *after* the latest
>> > feature release has it's branch cut.
>> >
>> > -chip
>>
>> To add to that, feature freeze for 4.2 is scheduled to be 5/31.
>>
>> We could have your code in a feature branch before that, and merge it
>> early june. It would then be included in 4.3
>>
>>
>>
>> >
>> > On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
>> >> ok. I will go with that.
>> >>
>> >> Thanks,
>> >> Dharmesh
>> >>
>> >> On Wed, May 8, 2013 at 1:08 AM, Chip Childers <
>> chip.childers@sungard.com>wrote:
>> >>
>> >>> On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
>> >>>> Hi,
>> >>>>
>> >>>> I am trying to move java package structure from com.cloud to
>> org.apache (
>> >>>> https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
>> thinking of
>> >>>> doing it the following way (Totally newbie), needed feedback on that.
>> >>>>
>> >>>> 1. grep "com.cloud" on the entire repo.
>> >>>> 2. update all package declarations using eclipse.
>> >>>> 3. Update scripts etc found in 1 manually.
>> >>>>
>> >>>> Will it be a good way to do it ? Any better suggestion ?
>> >>>>
>> >>>> Thanks,
>> >>>> Dharmesh
>> >>>
>> >>> That seems like a reasonable approach. We will probably want to
>> create
>> >>> a branch when you submit a patch for this, and apply it there... just
>> >>> to spend some time ensuring that the changes work.
>> >>>
>> >>> -chip
>> >>>
>>
>>
>
Re: Suggestion needed for CLOUDSTACK-212
Posted by Dharmesh Kakadia <dh...@gmail.com>.
I have started refactoring !! I am planning to finish refactoring by
tomorrow. I will then need help and guidance in doing testing,branching
etc. Let's try this out !!
Thanks,
Dharmesh
On Wed, May 8, 2013 at 7:20 PM, Sebastien Goasguen <ru...@gmail.com> wrote:
>
> On May 8, 2013, at 9:30 AM, Chip Childers <ch...@sungard.com>
> wrote:
>
> > Dharmesh,
> >
> > I'd also suggest that you actually plan on submitting this after the 4.2
> > feature freeze, to be included in 4.3. This is the type of change that
> > has bitten us with almost every release... and doing it close to the
> > end of the merge window may not be a good idea. Our general preference
> > is to do these types of changes in master right *after* the latest
> > feature release has it's branch cut.
> >
> > -chip
>
> To add to that, feature freeze for 4.2 is scheduled to be 5/31.
>
> We could have your code in a feature branch before that, and merge it
> early june. It would then be included in 4.3
>
>
>
> >
> > On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
> >> ok. I will go with that.
> >>
> >> Thanks,
> >> Dharmesh
> >>
> >> On Wed, May 8, 2013 at 1:08 AM, Chip Childers <
> chip.childers@sungard.com>wrote:
> >>
> >>> On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> >>>> Hi,
> >>>>
> >>>> I am trying to move java package structure from com.cloud to
> org.apache (
> >>>> https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am thinking
> of
> >>>> doing it the following way (Totally newbie), needed feedback on that.
> >>>>
> >>>> 1. grep "com.cloud" on the entire repo.
> >>>> 2. update all package declarations using eclipse.
> >>>> 3. Update scripts etc found in 1 manually.
> >>>>
> >>>> Will it be a good way to do it ? Any better suggestion ?
> >>>>
> >>>> Thanks,
> >>>> Dharmesh
> >>>
> >>> That seems like a reasonable approach. We will probably want to create
> >>> a branch when you submit a patch for this, and apply it there... just
> >>> to spend some time ensuring that the changes work.
> >>>
> >>> -chip
> >>>
>
>
Re: Suggestion needed for CLOUDSTACK-212
Posted by Sebastien Goasguen <ru...@gmail.com>.
On May 8, 2013, at 9:30 AM, Chip Childers <ch...@sungard.com> wrote:
> Dharmesh,
>
> I'd also suggest that you actually plan on submitting this after the 4.2
> feature freeze, to be included in 4.3. This is the type of change that
> has bitten us with almost every release... and doing it close to the
> end of the merge window may not be a good idea. Our general preference
> is to do these types of changes in master right *after* the latest
> feature release has it's branch cut.
>
> -chip
To add to that, feature freeze for 4.2 is scheduled to be 5/31.
We could have your code in a feature branch before that, and merge it early june. It would then be included in 4.3
>
> On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
>> ok. I will go with that.
>>
>> Thanks,
>> Dharmesh
>>
>> On Wed, May 8, 2013 at 1:08 AM, Chip Childers <ch...@sungard.com>wrote:
>>
>>> On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
>>>> Hi,
>>>>
>>>> I am trying to move java package structure from com.cloud to org.apache (
>>>> https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am thinking of
>>>> doing it the following way (Totally newbie), needed feedback on that.
>>>>
>>>> 1. grep "com.cloud" on the entire repo.
>>>> 2. update all package declarations using eclipse.
>>>> 3. Update scripts etc found in 1 manually.
>>>>
>>>> Will it be a good way to do it ? Any better suggestion ?
>>>>
>>>> Thanks,
>>>> Dharmesh
>>>
>>> That seems like a reasonable approach. We will probably want to create
>>> a branch when you submit a patch for this, and apply it there... just
>>> to spend some time ensuring that the changes work.
>>>
>>> -chip
>>>
Re: Suggestion needed for CLOUDSTACK-212
Posted by Sebastien Goasguen <ru...@gmail.com>.
On 7/1/13 8:11 AM, Dharmesh Kakadia wrote:
> Hi David,
>
> I have submitted a patch yesterday. It migrates com.cloud.network o
> org.apache.network. Please let me know if this is fine so that I can go on
> for the rest of the packages.
>
> Thanks,
> Dharmesh
>
Can you send me another patch created with git format-patch
I will create a topic branch and put the patch there.
thanks
thanks
>
> On Sat, Jun 29, 2013 at 10:09 PM, David Nalley<da...@gnsa.us> wrote:
>
>
>> On Fri, Jun 28, 2013 at 4:05 AM, Sebastien Goasguen<ru...@gmail.com>
>> wrote:
>>
>>> On Jun 27, 2013, at 1:23 PM, Dharmesh Kakadia<dh...@gmail.com>
>>>
>> wrote:
>>
>>>
>>>> Hi,
>>>>
>>>> I misunderstood the feature freeze. This has been assigned to fix in
>>>> Version 4.2 on jira. As per this discussion, should I change it to 4.3 ?
>>>>
>>> Dharmesh, can you give us the pointer to github where you put the latest
>>>
>> changes on this ?
>>
>>> Did you rebase against the latest master lately ?
>>>
>>> -sebastien
>>>
>>>
>> Dharmesh:
>> 4.2 has branched, and I'd like to get this up for review - can you get
>> us a patch and push it to ReviewBoard?
>>
>> --David
>>
>>
>
Re: Suggestion needed for CLOUDSTACK-212
Posted by Dharmesh Kakadia <dh...@gmail.com>.
Hi David,
I have submitted a patch yesterday. It migrates com.cloud.network o
org.apache.network. Please let me know if this is fine so that I can go on
for the rest of the packages.
Thanks,
Dharmesh
On Sat, Jun 29, 2013 at 10:09 PM, David Nalley <da...@gnsa.us> wrote:
> On Fri, Jun 28, 2013 at 4:05 AM, Sebastien Goasguen <ru...@gmail.com>
> wrote:
> >
> > On Jun 27, 2013, at 1:23 PM, Dharmesh Kakadia <dh...@gmail.com>
> wrote:
> >
> >> Hi,
> >>
> >> I misunderstood the feature freeze. This has been assigned to fix in
> >> Version 4.2 on jira. As per this discussion, should I change it to 4.3 ?
> >
> > Dharmesh, can you give us the pointer to github where you put the latest
> changes on this ?
> >
> > Did you rebase against the latest master lately ?
> >
> > -sebastien
> >
>
> Dharmesh:
> 4.2 has branched, and I'd like to get this up for review - can you get
> us a patch and push it to ReviewBoard?
>
> --David
>
Re: Suggestion needed for CLOUDSTACK-212
Posted by David Nalley <da...@gnsa.us>.
On Fri, Jun 28, 2013 at 4:05 AM, Sebastien Goasguen <ru...@gmail.com> wrote:
>
> On Jun 27, 2013, at 1:23 PM, Dharmesh Kakadia <dh...@gmail.com> wrote:
>
>> Hi,
>>
>> I misunderstood the feature freeze. This has been assigned to fix in
>> Version 4.2 on jira. As per this discussion, should I change it to 4.3 ?
>
> Dharmesh, can you give us the pointer to github where you put the latest changes on this ?
>
> Did you rebase against the latest master lately ?
>
> -sebastien
>
Dharmesh:
4.2 has branched, and I'd like to get this up for review - can you get
us a patch and push it to ReviewBoard?
--David
Re: Suggestion needed for CLOUDSTACK-212
Posted by Sebastien Goasguen <ru...@gmail.com>.
On Jun 27, 2013, at 1:23 PM, Dharmesh Kakadia <dh...@gmail.com> wrote:
> Hi,
>
> I misunderstood the feature freeze. This has been assigned to fix in
> Version 4.2 on jira. As per this discussion, should I change it to 4.3 ?
Dharmesh, can you give us the pointer to github where you put the latest changes on this ?
Did you rebase against the latest master lately ?
-sebastien
>
> Thanks,
> Dharmesh
>
>
> On Sat, May 11, 2013 at 10:13 AM, Dharmesh Kakadia <dh...@gmail.com>wrote:
>
>> ok. great.
>>
>> Thanks,
>> Dharmesh
>>
>>
>> On Sat, May 11, 2013 at 5:53 AM, David Nalley <da...@gnsa.us> wrote:
>>
>>> Dharmesh:
>>>
>>> Thanks for tackling this - I imagine there might be a little bit of churn,
>>> as features finally land in master, but shouldn't be much - I may pull
>>> this
>>> into a feature branch, and we can routinely rebase and see where we stand.
>>>
>>> Thanks for being patient and flexible.
>>>
>>> --David
>>>
>>> On Friday, May 10, 2013, Dharmesh Kakadia wrote:
>>>
>>>> Just saw this. I have done the refactoring and code is available at
>>>>
>>>>
>>> https://github.com/dharmeshkakadia/incubator-cloudstack/tree/com.cloud-to-org.apache-refactoringto
>>>> try. In case we want to do it after 4.2-freeze, I am ready to redo it.
>>>>
>>>> Thanks,
>>>> Dharmesh
>>>>
>>>>
>>>> On Fri, May 10, 2013 at 3:28 AM, Animesh Chaturvedi <
>>>> animesh.chaturvedi@citrix.com <javascript:;>> wrote:
>>>>
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Chip Childers [mailto:chip.childers@sungard.com<javascript:;>]
>>>>>> Sent: Wednesday, May 08, 2013 6:31 AM
>>>>>> To: dev@cloudstack.apache.org <javascript:;>
>>>>>> Subject: Re: Suggestion needed for CLOUDSTACK-212
>>>>>>
>>>>>> Dharmesh,
>>>>>>
>>>>>> I'd also suggest that you actually plan on submitting this after the
>>>> 4.2
>>>>> feature
>>>>>> freeze, to be included in 4.3. This is the type of change that has
>>>>> bitten us
>>>>>> with almost every release... and doing it close to the end of the
>>>> merge
>>>>>> window may not be a good idea. Our general preference is to do
>>> these
>>>>> types
>>>>>> of changes in master right *after* the latest feature release has
>>> it's
>>>>> branch
>>>>>> cut.
>>>>>>
>>>>>> -chip
>>>>> [Animesh>] yes 4.2 freeze is just 3 weeks out. This can be merged into
>>>>> master in early June
>>>>>>
>>>>>> On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
>>>>>>> ok. I will go with that.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Dharmesh
>>>>>>>
>>>>>>> On Wed, May 8, 2013 at 1:08 AM, Chip Childers
>>>>>> <chip.childers@sungard.com <javascript:;>>wrote:
>>>>>>>
>>>>>>>> On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia
>>> wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I am trying to move java package structure from com.cloud to
>>>>>>>>> org.apache (
>>>>>>>>> https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
>>>>>> thinking of doing it the following way (Totally newbie), needed
>>>> feedback
>>>>> on
>>>>>> that.
>>>>>>>>>
>>>>>>>>> 1. grep "com.cloud" on the entire repo.
>>>>>>>>> 2. update all package declarations using eclipse.
>>>>>>>>> 3. Update scripts etc found in 1 manually.
>>>>>>>>>
>>>>>>>>> Will it be a good way to do it ? Any better suggestion ?
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Dharmesh
>>>>>>>>
>>>>>>>> That seems like a reasonable approach. We will probably want to
>>>>>>>> create a branch when you submit a patch for this, and apply it
>>>>>>>> there... just to spend some time ensuring that the changes
>>> work.
>>>>>>>>
>>>>>>>> -chip
>>>>>>>>
>>>>>
>>>>
>>>
>>
>>
Re: Suggestion needed for CLOUDSTACK-212
Posted by Dharmesh Kakadia <dh...@gmail.com>.
Hi,
I misunderstood the feature freeze. This has been assigned to fix in
Version 4.2 on jira. As per this discussion, should I change it to 4.3 ?
Thanks,
Dharmesh
On Sat, May 11, 2013 at 10:13 AM, Dharmesh Kakadia <dh...@gmail.com>wrote:
> ok. great.
>
> Thanks,
> Dharmesh
>
>
> On Sat, May 11, 2013 at 5:53 AM, David Nalley <da...@gnsa.us> wrote:
>
>> Dharmesh:
>>
>> Thanks for tackling this - I imagine there might be a little bit of churn,
>> as features finally land in master, but shouldn't be much - I may pull
>> this
>> into a feature branch, and we can routinely rebase and see where we stand.
>>
>> Thanks for being patient and flexible.
>>
>> --David
>>
>> On Friday, May 10, 2013, Dharmesh Kakadia wrote:
>>
>> > Just saw this. I have done the refactoring and code is available at
>> >
>> >
>> https://github.com/dharmeshkakadia/incubator-cloudstack/tree/com.cloud-to-org.apache-refactoringto
>> > try. In case we want to do it after 4.2-freeze, I am ready to redo it.
>> >
>> > Thanks,
>> > Dharmesh
>> >
>> >
>> > On Fri, May 10, 2013 at 3:28 AM, Animesh Chaturvedi <
>> > animesh.chaturvedi@citrix.com <javascript:;>> wrote:
>> >
>> > >
>> > >
>> > > > -----Original Message-----
>> > > > From: Chip Childers [mailto:chip.childers@sungard.com<javascript:;>]
>> > > > Sent: Wednesday, May 08, 2013 6:31 AM
>> > > > To: dev@cloudstack.apache.org <javascript:;>
>> > > > Subject: Re: Suggestion needed for CLOUDSTACK-212
>> > > >
>> > > > Dharmesh,
>> > > >
>> > > > I'd also suggest that you actually plan on submitting this after the
>> > 4.2
>> > > feature
>> > > > freeze, to be included in 4.3. This is the type of change that has
>> > > bitten us
>> > > > with almost every release... and doing it close to the end of the
>> > merge
>> > > > window may not be a good idea. Our general preference is to do
>> these
>> > > types
>> > > > of changes in master right *after* the latest feature release has
>> it's
>> > > branch
>> > > > cut.
>> > > >
>> > > > -chip
>> > > [Animesh>] yes 4.2 freeze is just 3 weeks out. This can be merged into
>> > > master in early June
>> > > >
>> > > > On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
>> > > > > ok. I will go with that.
>> > > > >
>> > > > > Thanks,
>> > > > > Dharmesh
>> > > > >
>> > > > > On Wed, May 8, 2013 at 1:08 AM, Chip Childers
>> > > > <chip.childers@sungard.com <javascript:;>>wrote:
>> > > > >
>> > > > > > On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia
>> wrote:
>> > > > > > > Hi,
>> > > > > > >
>> > > > > > > I am trying to move java package structure from com.cloud to
>> > > > > > > org.apache (
>> > > > > > > https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
>> > > > thinking of doing it the following way (Totally newbie), needed
>> > feedback
>> > > on
>> > > > that.
>> > > > > > >
>> > > > > > > 1. grep "com.cloud" on the entire repo.
>> > > > > > > 2. update all package declarations using eclipse.
>> > > > > > > 3. Update scripts etc found in 1 manually.
>> > > > > > >
>> > > > > > > Will it be a good way to do it ? Any better suggestion ?
>> > > > > > >
>> > > > > > > Thanks,
>> > > > > > > Dharmesh
>> > > > > >
>> > > > > > That seems like a reasonable approach. We will probably want to
>> > > > > > create a branch when you submit a patch for this, and apply it
>> > > > > > there... just to spend some time ensuring that the changes
>> work.
>> > > > > >
>> > > > > > -chip
>> > > > > >
>> > >
>> >
>>
>
>
Re: Suggestion needed for CLOUDSTACK-212
Posted by Dharmesh Kakadia <dh...@gmail.com>.
ok. great.
Thanks,
Dharmesh
On Sat, May 11, 2013 at 5:53 AM, David Nalley <da...@gnsa.us> wrote:
> Dharmesh:
>
> Thanks for tackling this - I imagine there might be a little bit of churn,
> as features finally land in master, but shouldn't be much - I may pull this
> into a feature branch, and we can routinely rebase and see where we stand.
>
> Thanks for being patient and flexible.
>
> --David
>
> On Friday, May 10, 2013, Dharmesh Kakadia wrote:
>
> > Just saw this. I have done the refactoring and code is available at
> >
> >
> https://github.com/dharmeshkakadia/incubator-cloudstack/tree/com.cloud-to-org.apache-refactoringto
> > try. In case we want to do it after 4.2-freeze, I am ready to redo it.
> >
> > Thanks,
> > Dharmesh
> >
> >
> > On Fri, May 10, 2013 at 3:28 AM, Animesh Chaturvedi <
> > animesh.chaturvedi@citrix.com <javascript:;>> wrote:
> >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Chip Childers [mailto:chip.childers@sungard.com<javascript:;>]
> > > > Sent: Wednesday, May 08, 2013 6:31 AM
> > > > To: dev@cloudstack.apache.org <javascript:;>
> > > > Subject: Re: Suggestion needed for CLOUDSTACK-212
> > > >
> > > > Dharmesh,
> > > >
> > > > I'd also suggest that you actually plan on submitting this after the
> > 4.2
> > > feature
> > > > freeze, to be included in 4.3. This is the type of change that has
> > > bitten us
> > > > with almost every release... and doing it close to the end of the
> > merge
> > > > window may not be a good idea. Our general preference is to do these
> > > types
> > > > of changes in master right *after* the latest feature release has
> it's
> > > branch
> > > > cut.
> > > >
> > > > -chip
> > > [Animesh>] yes 4.2 freeze is just 3 weeks out. This can be merged into
> > > master in early June
> > > >
> > > > On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
> > > > > ok. I will go with that.
> > > > >
> > > > > Thanks,
> > > > > Dharmesh
> > > > >
> > > > > On Wed, May 8, 2013 at 1:08 AM, Chip Childers
> > > > <chip.childers@sungard.com <javascript:;>>wrote:
> > > > >
> > > > > > On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > I am trying to move java package structure from com.cloud to
> > > > > > > org.apache (
> > > > > > > https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
> > > > thinking of doing it the following way (Totally newbie), needed
> > feedback
> > > on
> > > > that.
> > > > > > >
> > > > > > > 1. grep "com.cloud" on the entire repo.
> > > > > > > 2. update all package declarations using eclipse.
> > > > > > > 3. Update scripts etc found in 1 manually.
> > > > > > >
> > > > > > > Will it be a good way to do it ? Any better suggestion ?
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Dharmesh
> > > > > >
> > > > > > That seems like a reasonable approach. We will probably want to
> > > > > > create a branch when you submit a patch for this, and apply it
> > > > > > there... just to spend some time ensuring that the changes work.
> > > > > >
> > > > > > -chip
> > > > > >
> > >
> >
>
Re: Suggestion needed for CLOUDSTACK-212
Posted by David Nalley <da...@gnsa.us>.
Dharmesh:
Thanks for tackling this - I imagine there might be a little bit of churn,
as features finally land in master, but shouldn't be much - I may pull this
into a feature branch, and we can routinely rebase and see where we stand.
Thanks for being patient and flexible.
--David
On Friday, May 10, 2013, Dharmesh Kakadia wrote:
> Just saw this. I have done the refactoring and code is available at
>
> https://github.com/dharmeshkakadia/incubator-cloudstack/tree/com.cloud-to-org.apache-refactoringto
> try. In case we want to do it after 4.2-freeze, I am ready to redo it.
>
> Thanks,
> Dharmesh
>
>
> On Fri, May 10, 2013 at 3:28 AM, Animesh Chaturvedi <
> animesh.chaturvedi@citrix.com <javascript:;>> wrote:
>
> >
> >
> > > -----Original Message-----
> > > From: Chip Childers [mailto:chip.childers@sungard.com <javascript:;>]
> > > Sent: Wednesday, May 08, 2013 6:31 AM
> > > To: dev@cloudstack.apache.org <javascript:;>
> > > Subject: Re: Suggestion needed for CLOUDSTACK-212
> > >
> > > Dharmesh,
> > >
> > > I'd also suggest that you actually plan on submitting this after the
> 4.2
> > feature
> > > freeze, to be included in 4.3. This is the type of change that has
> > bitten us
> > > with almost every release... and doing it close to the end of the
> merge
> > > window may not be a good idea. Our general preference is to do these
> > types
> > > of changes in master right *after* the latest feature release has it's
> > branch
> > > cut.
> > >
> > > -chip
> > [Animesh>] yes 4.2 freeze is just 3 weeks out. This can be merged into
> > master in early June
> > >
> > > On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
> > > > ok. I will go with that.
> > > >
> > > > Thanks,
> > > > Dharmesh
> > > >
> > > > On Wed, May 8, 2013 at 1:08 AM, Chip Childers
> > > <chip.childers@sungard.com <javascript:;>>wrote:
> > > >
> > > > > On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> > > > > > Hi,
> > > > > >
> > > > > > I am trying to move java package structure from com.cloud to
> > > > > > org.apache (
> > > > > > https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
> > > thinking of doing it the following way (Totally newbie), needed
> feedback
> > on
> > > that.
> > > > > >
> > > > > > 1. grep "com.cloud" on the entire repo.
> > > > > > 2. update all package declarations using eclipse.
> > > > > > 3. Update scripts etc found in 1 manually.
> > > > > >
> > > > > > Will it be a good way to do it ? Any better suggestion ?
> > > > > >
> > > > > > Thanks,
> > > > > > Dharmesh
> > > > >
> > > > > That seems like a reasonable approach. We will probably want to
> > > > > create a branch when you submit a patch for this, and apply it
> > > > > there... just to spend some time ensuring that the changes work.
> > > > >
> > > > > -chip
> > > > >
> >
>
Re: Suggestion needed for CLOUDSTACK-212
Posted by Dharmesh Kakadia <dh...@gmail.com>.
Just saw this. I have done the refactoring and code is available at
https://github.com/dharmeshkakadia/incubator-cloudstack/tree/com.cloud-to-org.apache-refactoringto
try. In case we want to do it after 4.2-freeze, I am ready to redo it.
Thanks,
Dharmesh
On Fri, May 10, 2013 at 3:28 AM, Animesh Chaturvedi <
animesh.chaturvedi@citrix.com> wrote:
>
>
> > -----Original Message-----
> > From: Chip Childers [mailto:chip.childers@sungard.com]
> > Sent: Wednesday, May 08, 2013 6:31 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Suggestion needed for CLOUDSTACK-212
> >
> > Dharmesh,
> >
> > I'd also suggest that you actually plan on submitting this after the 4.2
> feature
> > freeze, to be included in 4.3. This is the type of change that has
> bitten us
> > with almost every release... and doing it close to the end of the merge
> > window may not be a good idea. Our general preference is to do these
> types
> > of changes in master right *after* the latest feature release has it's
> branch
> > cut.
> >
> > -chip
> [Animesh>] yes 4.2 freeze is just 3 weeks out. This can be merged into
> master in early June
> >
> > On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
> > > ok. I will go with that.
> > >
> > > Thanks,
> > > Dharmesh
> > >
> > > On Wed, May 8, 2013 at 1:08 AM, Chip Childers
> > <ch...@sungard.com>wrote:
> > >
> > > > On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> > > > > Hi,
> > > > >
> > > > > I am trying to move java package structure from com.cloud to
> > > > > org.apache (
> > > > > https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
> > thinking of doing it the following way (Totally newbie), needed feedback
> on
> > that.
> > > > >
> > > > > 1. grep "com.cloud" on the entire repo.
> > > > > 2. update all package declarations using eclipse.
> > > > > 3. Update scripts etc found in 1 manually.
> > > > >
> > > > > Will it be a good way to do it ? Any better suggestion ?
> > > > >
> > > > > Thanks,
> > > > > Dharmesh
> > > >
> > > > That seems like a reasonable approach. We will probably want to
> > > > create a branch when you submit a patch for this, and apply it
> > > > there... just to spend some time ensuring that the changes work.
> > > >
> > > > -chip
> > > >
>
RE: Suggestion needed for CLOUDSTACK-212
Posted by Animesh Chaturvedi <an...@citrix.com>.
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Wednesday, May 08, 2013 6:31 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Suggestion needed for CLOUDSTACK-212
>
> Dharmesh,
>
> I'd also suggest that you actually plan on submitting this after the 4.2 feature
> freeze, to be included in 4.3. This is the type of change that has bitten us
> with almost every release... and doing it close to the end of the merge
> window may not be a good idea. Our general preference is to do these types
> of changes in master right *after* the latest feature release has it's branch
> cut.
>
> -chip
[Animesh>] yes 4.2 freeze is just 3 weeks out. This can be merged into master in early June
>
> On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
> > ok. I will go with that.
> >
> > Thanks,
> > Dharmesh
> >
> > On Wed, May 8, 2013 at 1:08 AM, Chip Childers
> <ch...@sungard.com>wrote:
> >
> > > On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> > > > Hi,
> > > >
> > > > I am trying to move java package structure from com.cloud to
> > > > org.apache (
> > > > https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am
> thinking of doing it the following way (Totally newbie), needed feedback on
> that.
> > > >
> > > > 1. grep "com.cloud" on the entire repo.
> > > > 2. update all package declarations using eclipse.
> > > > 3. Update scripts etc found in 1 manually.
> > > >
> > > > Will it be a good way to do it ? Any better suggestion ?
> > > >
> > > > Thanks,
> > > > Dharmesh
> > >
> > > That seems like a reasonable approach. We will probably want to
> > > create a branch when you submit a patch for this, and apply it
> > > there... just to spend some time ensuring that the changes work.
> > >
> > > -chip
> > >
Re: Suggestion needed for CLOUDSTACK-212
Posted by Chip Childers <ch...@sungard.com>.
Dharmesh,
I'd also suggest that you actually plan on submitting this after the 4.2
feature freeze, to be included in 4.3. This is the type of change that
has bitten us with almost every release... and doing it close to the
end of the merge window may not be a good idea. Our general preference
is to do these types of changes in master right *after* the latest
feature release has it's branch cut.
-chip
On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote:
> ok. I will go with that.
>
> Thanks,
> Dharmesh
>
> On Wed, May 8, 2013 at 1:08 AM, Chip Childers <ch...@sungard.com>wrote:
>
> > On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> > > Hi,
> > >
> > > I am trying to move java package structure from com.cloud to org.apache (
> > > https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am thinking of
> > > doing it the following way (Totally newbie), needed feedback on that.
> > >
> > > 1. grep "com.cloud" on the entire repo.
> > > 2. update all package declarations using eclipse.
> > > 3. Update scripts etc found in 1 manually.
> > >
> > > Will it be a good way to do it ? Any better suggestion ?
> > >
> > > Thanks,
> > > Dharmesh
> >
> > That seems like a reasonable approach. We will probably want to create
> > a branch when you submit a patch for this, and apply it there... just
> > to spend some time ensuring that the changes work.
> >
> > -chip
> >
Re: Suggestion needed for CLOUDSTACK-212
Posted by Dharmesh Kakadia <dh...@gmail.com>.
ok. I will go with that.
Thanks,
Dharmesh
On Wed, May 8, 2013 at 1:08 AM, Chip Childers <ch...@sungard.com>wrote:
> On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> > Hi,
> >
> > I am trying to move java package structure from com.cloud to org.apache (
> > https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am thinking of
> > doing it the following way (Totally newbie), needed feedback on that.
> >
> > 1. grep "com.cloud" on the entire repo.
> > 2. update all package declarations using eclipse.
> > 3. Update scripts etc found in 1 manually.
> >
> > Will it be a good way to do it ? Any better suggestion ?
> >
> > Thanks,
> > Dharmesh
>
> That seems like a reasonable approach. We will probably want to create
> a branch when you submit a patch for this, and apply it there... just
> to spend some time ensuring that the changes work.
>
> -chip
>
Re: Suggestion needed for CLOUDSTACK-212
Posted by Chip Childers <ch...@sungard.com>.
On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote:
> Hi,
>
> I am trying to move java package structure from com.cloud to org.apache (
> https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am thinking of
> doing it the following way (Totally newbie), needed feedback on that.
>
> 1. grep "com.cloud" on the entire repo.
> 2. update all package declarations using eclipse.
> 3. Update scripts etc found in 1 manually.
>
> Will it be a good way to do it ? Any better suggestion ?
>
> Thanks,
> Dharmesh
That seems like a reasonable approach. We will probably want to create
a branch when you submit a patch for this, and apply it there... just
to spend some time ensuring that the changes work.
-chip