You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2023/01/09 17:27:04 UTC
[GitHub] [helix] Marcosrico opened a new pull request, #2335: Crud create
Marcosrico opened a new pull request, #2335:
URL: https://github.com/apache/helix/pull/2335
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
(#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
(Write a concise description including what, why, how)
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] Marcosrico commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations
Posted by GitBox <gi...@apache.org>.
Marcosrico commented on code in PR #2335:
URL: https://github.com/apache/helix/pull/2335#discussion_r1067435044
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -70,11 +90,22 @@ public Object update(String key, DataUpdater updater) {
@Override
public Stat exists(String key) {
- return null;
- }
-
- @Override
- public Object get(String key) {
+ org.apache.zookeeper.data.Stat zkStats;
Review Comment:
yes this will be updated with pr 2327 once it's merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on code in PR #2335:
URL: https://github.com/apache/helix/pull/2335#discussion_r1068745528
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -67,14 +67,33 @@ public ZkMetaClient(ZkMetaClientConfig config) {
}
@Override
- public void create(String key, T data) {
- // TODO: This function is implemented only for test. It does not have proper error handling
- _zkClient.create(key, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT);
+ public void create(String key, Object data) {
+ try {
+ create(key, data, EntryMode.PERSISTENT);
+ } catch (Exception e) {
+ throw new MetaClientException(e);
+ }
}
@Override
- public void create(String key, T data, EntryMode mode) {
+ public void create(String key, Object data, MetaClientInterface.EntryMode mode) {
+ try{
+ _zkClient.create(key, data, metaClientModeToZkMode(mode));
+ } catch (ZkException | KeeperException e) {
+ throw new MetaClientException(e);
+ }
+ }
+
+ private CreateMode metaClientModeToZkMode(EntryMode mode) throws KeeperException {
+ int zkFlag = -1;
+ if (mode.name().equals(EntryMode.PERSISTENT.name())) {
+ zkFlag = 0;
+ }
+ if (mode.name().equals(EntryMode.EPHEMERAL.name())) {
+ zkFlag = 1;
Review Comment:
can we just return the mode here? Including a separate int value could be confusing.
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -67,14 +67,33 @@ public ZkMetaClient(ZkMetaClientConfig config) {
}
@Override
- public void create(String key, T data) {
- // TODO: This function is implemented only for test. It does not have proper error handling
- _zkClient.create(key, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT);
+ public void create(String key, Object data) {
+ try {
+ create(key, data, EntryMode.PERSISTENT);
+ } catch (Exception e) {
+ throw new MetaClientException(e);
+ }
}
@Override
- public void create(String key, T data, EntryMode mode) {
+ public void create(String key, Object data, MetaClientInterface.EntryMode mode) {
+ try{
+ _zkClient.create(key, data, metaClientModeToZkMode(mode));
+ } catch (ZkException | KeeperException e) {
+ throw new MetaClientException(e);
+ }
+ }
+
+ private CreateMode metaClientModeToZkMode(EntryMode mode) throws KeeperException {
+ int zkFlag = -1;
+ if (mode.name().equals(EntryMode.PERSISTENT.name())) {
+ zkFlag = 0;
+ }
+ if (mode.name().equals(EntryMode.EPHEMERAL.name())) {
+ zkFlag = 1;
Review Comment:
can we just return the mode here? Including an extra int value could be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on code in PR #2335:
URL: https://github.com/apache/helix/pull/2335#discussion_r1068780318
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -67,14 +67,33 @@ public ZkMetaClient(ZkMetaClientConfig config) {
}
@Override
- public void create(String key, T data) {
- // TODO: This function is implemented only for test. It does not have proper error handling
- _zkClient.create(key, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT);
+ public void create(String key, Object data) {
+ try {
+ create(key, data, EntryMode.PERSISTENT);
+ } catch (Exception e) {
+ throw new MetaClientException(e);
+ }
}
@Override
- public void create(String key, T data, EntryMode mode) {
+ public void create(String key, Object data, MetaClientInterface.EntryMode mode) {
+ try{
+ _zkClient.create(key, data, metaClientModeToZkMode(mode));
+ } catch (ZkException | KeeperException e) {
+ throw new MetaClientException(e);
+ }
+ }
+
+ private CreateMode metaClientModeToZkMode(EntryMode mode) throws KeeperException {
+ int zkFlag = -1;
+ if (mode.name().equals(EntryMode.PERSISTENT.name())) {
Review Comment:
A better way is to compare directly on the Enum level with switch or use EnumMap. Comparing string is unstable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu merged pull request #2335: MetaClient - Implementation of Create from CRUD operations
Posted by GitBox <gi...@apache.org>.
xyuanlu merged PR #2335:
URL: https://github.com/apache/helix/pull/2335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] Marcosrico commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations
Posted by GitBox <gi...@apache.org>.
Marcosrico commented on code in PR #2335:
URL: https://github.com/apache/helix/pull/2335#discussion_r1068491849
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -50,12 +55,27 @@ public ZkMetaClient(ZkMetaClientConfig config) {
@Override
public void create(String key, Object data) {
-
+ try {
+ create(key, data, EntryMode.PERSISTENT);
+ } catch (Exception e) {
+ throw new MetaClientException(e);
+ }
}
@Override
- public void create(String key, Object data, EntryMode mode) {
-
+ public void create(String key, Object data, MetaClientInterface.EntryMode mode) {
+ int zkFlag = -1;
+ if (mode.name().equals(EntryMode.PERSISTENT.name())) {
+ zkFlag = 0;
Review Comment:
Sounds good! I'll make a metaClient mode to zk Mode helper function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on code in PR #2335:
URL: https://github.com/apache/helix/pull/2335#discussion_r1068745128
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -67,14 +67,33 @@ public ZkMetaClient(ZkMetaClientConfig config) {
}
@Override
- public void create(String key, T data) {
- // TODO: This function is implemented only for test. It does not have proper error handling
- _zkClient.create(key, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT);
+ public void create(String key, Object data) {
+ try {
+ create(key, data, EntryMode.PERSISTENT);
+ } catch (Exception e) {
+ throw new MetaClientException(e);
+ }
}
@Override
- public void create(String key, T data, EntryMode mode) {
+ public void create(String key, Object data, MetaClientInterface.EntryMode mode) {
+ try{
+ _zkClient.create(key, data, metaClientModeToZkMode(mode));
+ } catch (ZkException | KeeperException e) {
+ throw new MetaClientException(e);
+ }
+ }
+
+ private CreateMode metaClientModeToZkMode(EntryMode mode) throws KeeperException {
Review Comment:
it can be a static method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on code in PR #2335:
URL: https://github.com/apache/helix/pull/2335#discussion_r1067373919
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -70,11 +90,22 @@ public Object update(String key, DataUpdater updater) {
@Override
public Stat exists(String key) {
- return null;
- }
-
- @Override
- public Object get(String key) {
+ org.apache.zookeeper.data.Stat zkStats;
Review Comment:
Please mark here as temp impl for test only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations
Posted by GitBox <gi...@apache.org>.
xyuanlu commented on code in PR #2335:
URL: https://github.com/apache/helix/pull/2335#discussion_r1068433562
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -50,12 +55,27 @@ public ZkMetaClient(ZkMetaClientConfig config) {
@Override
public void create(String key, Object data) {
-
+ try {
+ create(key, data, EntryMode.PERSISTENT);
+ } catch (Exception e) {
+ throw new MetaClientException(e);
+ }
}
@Override
- public void create(String key, Object data, EntryMode mode) {
-
+ public void create(String key, Object data, MetaClientInterface.EntryMode mode) {
+ int zkFlag = -1;
+ if (mode.name().equals(EntryMode.PERSISTENT.name())) {
+ zkFlag = 0;
Review Comment:
Maybe a simple translator class will be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] Marcosrico commented on pull request #2335: Crud create
Posted by GitBox <gi...@apache.org>.
Marcosrico commented on PR #2335:
URL: https://github.com/apache/helix/pull/2335#issuecomment-1376363281
@qqu0127 I marked it as review as I was hoping as soon as 2327 get's merged I can fix the merge conflicts and be more streamlined with the process as I have another PR blocked on this one. I'm not sure what the general convention is for these types of situation and the conflicts are not relevant to the core logic of this PR. Please let me know what should be done in these scenarios, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on pull request #2335: Crud create
Posted by GitBox <gi...@apache.org>.
qqu0127 commented on PR #2335:
URL: https://github.com/apache/helix/pull/2335#issuecomment-1376025159
Is this ready to review or not?
This is going to be conflict with https://github.com/apache/helix/pull/2327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations
Posted by GitBox <gi...@apache.org>.
desaikomal commented on code in PR #2335:
URL: https://github.com/apache/helix/pull/2335#discussion_r1068796629
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -67,14 +67,33 @@ public ZkMetaClient(ZkMetaClientConfig config) {
}
@Override
- public void create(String key, T data) {
- // TODO: This function is implemented only for test. It does not have proper error handling
- _zkClient.create(key, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT);
+ public void create(String key, Object data) {
+ try {
+ create(key, data, EntryMode.PERSISTENT);
+ } catch (Exception e) {
+ throw new MetaClientException(e);
+ }
}
@Override
- public void create(String key, T data, EntryMode mode) {
+ public void create(String key, Object data, MetaClientInterface.EntryMode mode) {
+ try{
+ _zkClient.create(key, data, metaClientModeToZkMode(mode));
+ } catch (ZkException | KeeperException e) {
+ throw new MetaClientException(e);
+ }
+ }
+
+ private CreateMode metaClientModeToZkMode(EntryMode mode) throws KeeperException {
+ int zkFlag = -1;
+ if (mode.name().equals(EntryMode.PERSISTENT.name())) {
Review Comment:
+1 - enums can be compared directly. and it will be faster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] Marcosrico commented on a diff in pull request #2335: MetaClient - Implementation of Create from CRUD operations
Posted by GitBox <gi...@apache.org>.
Marcosrico commented on code in PR #2335:
URL: https://github.com/apache/helix/pull/2335#discussion_r1070467931
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -67,14 +67,33 @@ public ZkMetaClient(ZkMetaClientConfig config) {
}
@Override
- public void create(String key, T data) {
- // TODO: This function is implemented only for test. It does not have proper error handling
- _zkClient.create(key, data, ZooDefs.Ids.OPEN_ACL_UNSAFE, CreateMode.PERSISTENT);
+ public void create(String key, Object data) {
+ try {
+ create(key, data, EntryMode.PERSISTENT);
+ } catch (Exception e) {
+ throw new MetaClientException(e);
+ }
}
@Override
- public void create(String key, T data, EntryMode mode) {
+ public void create(String key, Object data, MetaClientInterface.EntryMode mode) {
+ try{
+ _zkClient.create(key, data, metaClientModeToZkMode(mode));
+ } catch (ZkException | KeeperException e) {
+ throw new MetaClientException(e);
+ }
+ }
+
+ private CreateMode metaClientModeToZkMode(EntryMode mode) throws KeeperException {
+ int zkFlag = -1;
+ if (mode.name().equals(EntryMode.PERSISTENT.name())) {
Review Comment:
Sounds good, thanks for the feedback. I modified it slightly further for even better readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] Marcosrico commented on pull request #2335: MetaClient - Implementation of Create from CRUD operations
Posted by GitBox <gi...@apache.org>.
Marcosrico commented on PR #2335:
URL: https://github.com/apache/helix/pull/2335#issuecomment-1386080645
This PR is ready to merge, approved by @xyuanlu
Commit message:
Metaclient - Implementation of Create from CRUD operations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org