[jira] [Commented] (OAK-10241) NPE while trying to get the BinaryDownload URI

["Marcel Reutegger (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-10241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17722726#comment-17722726 ] 

Marcel Reutegger commented on OAK-10241:
----------------------------------------

Proposed fix in https://github.com/apache/jackrabbit-oak/pull/939

[~mattvryan], WDYT?

> NPE while trying to get the BinaryDownload URI
> ----------------------------------------------
>
>                 Key: OAK-10241
>                 URL: https://issues.apache.org/jira/browse/OAK-10241
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: store-spi
>            Reporter: Manas Kumar Maji
>            Assignee: Marcel Reutegger
>            Priority: Minor
>              Labels: oak
>
> The line of code at [BinaryImpl.java:L104|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-spi/src/main/java/org/apache/jackrabbit/oak/plugins/value/jcr/BinaryImpl.java#L104] should be handling the possibility that {{getBinaryValue()}} could return {{null}}.
> When trying to get a SAS uri for a binary, we got the following error
> {noformat}
> java.lang.NullPointerException: null
> 	at org.apache.jackrabbit.oak.plugins.value.jcr.BinaryImpl.getURI(BinaryImpl.java:104) [org.apache.jackrabbit.oak-store-spi:1.48.0.T20230202132234-aa49252]
> {noformat}
> Unfortunately we don't know much about the resource in question and why the {{value}} of this would not be {{{}PropertyType.BINARY{}}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)