You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by "Rick Curtis (JIRA)" <ji...@apache.org> on 2010/04/19 17:24:50 UTC
[jira] Created: (OPENJPA-1634) Loading JAXB meta data when using
MetaDataRepository preloading isn't thead safe.
Loading JAXB meta data when using MetaDataRepository preloading isn't thead safe.
---------------------------------------------------------------------------------
Key: OPENJPA-1634
URL: https://issues.apache.org/jira/browse/OPENJPA-1634
Project: OpenJPA
Issue Type: Bug
Reporter: Rick Curtis
Assignee: Rick Curtis
This problem was originally reported in OPENJPA-1631 where a NPE was fixed, but this JIRA will be used to fix the root problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (OPENJPA-1634) Loading JAXB meta data when using
MetaDataRepository preloading isn't thead safe.
Posted by "Rick Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Curtis resolved OPENJPA-1634.
----------------------------------
Resolution: Fixed
Committed revision 940093 to trunk.
> Loading JAXB meta data when using MetaDataRepository preloading isn't thead safe.
> ---------------------------------------------------------------------------------
>
> Key: OPENJPA-1634
> URL: https://issues.apache.org/jira/browse/OPENJPA-1634
> Project: OpenJPA
> Issue Type: Bug
> Components: kernel
> Affects Versions: 2.0.0, 2.1.0
> Reporter: Rick Curtis
> Assignee: Rick Curtis
> Fix For: 2.1.0
>
> Attachments: OPENJPA-1634.patch
>
>
> This problem was originally reported in OPENJPA-1631 where a NPE was fixed, but this JIRA will be used to fix the root problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OPENJPA-1634) Loading JAXB meta data when using
MetaDataRepository preloading isn't thead safe.
Posted by "Catalina Wei (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859068#action_12859068 ]
Catalina Wei commented on OPENJPA-1634:
---------------------------------------
1. NULL pointer check for 'cls' the following code block:
+ // Preload XML MetaData
+ for(Class<?> cls : loaded){
+ ClassMetaData cmd = getCachedMetaData(cls);
+ getXMLMetaData(cls);
+ for(FieldMetaData fmd : cmd.getFields()){
+ getXMLMetaData(fmd.getDeclaredType());
+ }
+ }
2. please verify the patch passes JUnit test TestXMLCustomerOrder in org.apache.openjpa.persistence.xmlmapping.query.
I can not recall the rational behaind the method signature of
getXMLMetaData(FieldMetaData fmd) in AbstractExpresionBuilder.traversePath()
If twith the path, TestXMLCustomerOrder passes, then it is OK to change the method signiture.
> Loading JAXB meta data when using MetaDataRepository preloading isn't thead safe.
> ---------------------------------------------------------------------------------
>
> Key: OPENJPA-1634
> URL: https://issues.apache.org/jira/browse/OPENJPA-1634
> Project: OpenJPA
> Issue Type: Bug
> Components: kernel
> Reporter: Rick Curtis
> Assignee: Rick Curtis
> Attachments: OPENJPA-1634.patch
>
>
> This problem was originally reported in OPENJPA-1631 where a NPE was fixed, but this JIRA will be used to fix the root problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1634) Loading JAXB meta data when using
MetaDataRepository preloading isn't thead safe.
Posted by "Rick Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Curtis updated OPENJPA-1634:
---------------------------------
Fix Version/s: 2.1.0
Affects Version/s: 2.0.0
2.1.0
> Loading JAXB meta data when using MetaDataRepository preloading isn't thead safe.
> ---------------------------------------------------------------------------------
>
> Key: OPENJPA-1634
> URL: https://issues.apache.org/jira/browse/OPENJPA-1634
> Project: OpenJPA
> Issue Type: Bug
> Components: kernel
> Affects Versions: 2.0.0, 2.1.0
> Reporter: Rick Curtis
> Assignee: Rick Curtis
> Fix For: 2.1.0
>
> Attachments: OPENJPA-1634.patch
>
>
> This problem was originally reported in OPENJPA-1631 where a NPE was fixed, but this JIRA will be used to fix the root problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1634) Loading JAXB meta data when using
MetaDataRepository preloading isn't thead safe.
Posted by "Rick Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Curtis updated OPENJPA-1634:
---------------------------------
Component/s: kernel
> Loading JAXB meta data when using MetaDataRepository preloading isn't thead safe.
> ---------------------------------------------------------------------------------
>
> Key: OPENJPA-1634
> URL: https://issues.apache.org/jira/browse/OPENJPA-1634
> Project: OpenJPA
> Issue Type: Bug
> Components: kernel
> Reporter: Rick Curtis
> Assignee: Rick Curtis
>
> This problem was originally reported in OPENJPA-1631 where a NPE was fixed, but this JIRA will be used to fix the root problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OPENJPA-1634) Loading JAXB meta data when using
MetaDataRepository preloading isn't thead safe.
Posted by "Rick Curtis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OPENJPA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Curtis updated OPENJPA-1634:
---------------------------------
Attachment: OPENJPA-1634.patch
Attaching a patch that refactors some of the JAXB parsing code to allow for easier preloading. This seems safe enough, but I'm wonder if I missed something with my changes.
> Loading JAXB meta data when using MetaDataRepository preloading isn't thead safe.
> ---------------------------------------------------------------------------------
>
> Key: OPENJPA-1634
> URL: https://issues.apache.org/jira/browse/OPENJPA-1634
> Project: OpenJPA
> Issue Type: Bug
> Components: kernel
> Reporter: Rick Curtis
> Assignee: Rick Curtis
> Attachments: OPENJPA-1634.patch
>
>
> This problem was originally reported in OPENJPA-1631 where a NPE was fixed, but this JIRA will be used to fix the root problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.