You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/04/09 02:21:28 UTC
Re: Review Request 20017: Added 'make bench' make target to run benchmark
tests under 'src/'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20017/
-----------------------------------------------------------
(Updated April 8, 2014, 5:21 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
BenM's comments.
Summary (updated)
-----------------
Added 'make bench' make target to run benchmark tests under 'src/'.
Bugs: MESOS-1190
https://issues.apache.org/jira/browse/MESOS-1190
Repository: mesos-git
Description (updated)
-------
- The 'benchmark' tests are the GTEST test fixtures or tests with the name containing 'BENCHMARK_'.
- The tests can be invoked by 'make bench' command or 'MESOS_BENCHMARK=1 make check'.
- These tests can also be run by <build>/bin/mesos-tests.sh --benchmark
Diffs (updated)
-----
Makefile.am bb96565a48f2fb70f38bf033945a63cb4c8b407c
src/tests/environment.hpp 02a897b07a04c5111e40d6ce3ad653a49cb9919b
src/tests/environment.cpp feeca042265eede40e87db3ee5ab89be04509a90
src/tests/flags.hpp 9760a7a1b074a759d0bd0e6d799f45f6a2dacc7e
src/tests/main.cpp ba9bf64babf037ac66a4ab7ae8f473bcb61ac0fd
Diff: https://reviews.apache.org/r/20017/diff/
Testing (updated)
-------
- make check
- make bench, which is equivalent of MESOS_BENCHMARK=1 make check
- make bench with GTESTS filters
- <build>/bin/mesos-tests.sh --benchmark, <build>/bin/mesos-tests.sh --no-benchmark, <build>/bin/mesos-tests.sh --help (checked output).
Thanks,
Jiang Yan Xu
Re: Review Request 20017: Added 'make bench' make target to run benchmark
tests under 'src/'.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20017/#review39865
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20017]
All tests passed.
- Mesos ReviewBot
On April 9, 2014, 12:21 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20017/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 12:21 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1190
> https://issues.apache.org/jira/browse/MESOS-1190
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - The 'benchmark' tests are the GTEST test fixtures or tests with the name containing 'BENCHMARK_'.
> - The tests can be invoked by 'make bench' command or 'MESOS_BENCHMARK=1 make check'.
> - These tests can also be run by <build>/bin/mesos-tests.sh --benchmark
>
>
> Diffs
> -----
>
> Makefile.am bb96565a48f2fb70f38bf033945a63cb4c8b407c
> src/tests/environment.hpp 02a897b07a04c5111e40d6ce3ad653a49cb9919b
> src/tests/environment.cpp feeca042265eede40e87db3ee5ab89be04509a90
> src/tests/flags.hpp 9760a7a1b074a759d0bd0e6d799f45f6a2dacc7e
> src/tests/main.cpp ba9bf64babf037ac66a4ab7ae8f473bcb61ac0fd
>
> Diff: https://reviews.apache.org/r/20017/diff/
>
>
> Testing
> -------
>
> - make check
> - make bench, which is equivalent of MESOS_BENCHMARK=1 make check
> - make bench with GTESTS filters
> - <build>/bin/mesos-tests.sh --benchmark, <build>/bin/mesos-tests.sh --no-benchmark, <build>/bin/mesos-tests.sh --help (checked output).
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 20017: Added 'make bench' make target to run benchmark
tests under 'src/'.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20017/#review39860
-----------------------------------------------------------
Ship it!
Makefile.am
<https://reviews.apache.org/r/20017/#comment72634>
Much better, thank you!
src/tests/environment.cpp
<https://reviews.apache.org/r/20017/#comment72635>
You could do without the Hence part :)
- Ben Mahler
On April 9, 2014, 12:21 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20017/
> -----------------------------------------------------------
>
> (Updated April 9, 2014, 12:21 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1190
> https://issues.apache.org/jira/browse/MESOS-1190
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - The 'benchmark' tests are the GTEST test fixtures or tests with the name containing 'BENCHMARK_'.
> - The tests can be invoked by 'make bench' command or 'MESOS_BENCHMARK=1 make check'.
> - These tests can also be run by <build>/bin/mesos-tests.sh --benchmark
>
>
> Diffs
> -----
>
> Makefile.am bb96565a48f2fb70f38bf033945a63cb4c8b407c
> src/tests/environment.hpp 02a897b07a04c5111e40d6ce3ad653a49cb9919b
> src/tests/environment.cpp feeca042265eede40e87db3ee5ab89be04509a90
> src/tests/flags.hpp 9760a7a1b074a759d0bd0e6d799f45f6a2dacc7e
> src/tests/main.cpp ba9bf64babf037ac66a4ab7ae8f473bcb61ac0fd
>
> Diff: https://reviews.apache.org/r/20017/diff/
>
>
> Testing
> -------
>
> - make check
> - make bench, which is equivalent of MESOS_BENCHMARK=1 make check
> - make bench with GTESTS filters
> - <build>/bin/mesos-tests.sh --benchmark, <build>/bin/mesos-tests.sh --no-benchmark, <build>/bin/mesos-tests.sh --help (checked output).
>
>
> Thanks,
>
> Jiang Yan Xu
>
>