You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2015/02/13 06:45:25 UTC

Re: Review Request 29196: Add some explain to PTF operator

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29196/
-----------------------------------------------------------

(Updated Feb. 13, 2015, 5:45 a.m.)


Review request for hive.


Changes
-------

Addressed comment


Bugs: HIVE-9138
    https://issues.apache.org/jira/browse/HIVE-9138


Repository: hive-git


Description
-------

PTFOperator does not explain anything in explain statement, making it hard to understand the internal works. 


Diffs (updated)
-----

  itests/src/test/resources/testconfiguration.properties 78ef0a0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java daf6cb8 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java f49b7cd 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java fad582a 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SamplePruner.java b0f4b47 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 6c1ab07 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c69ed69 
  ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java 5856743 
  ql/src/java/org/apache/hadoop/hive/ql/plan/PTFDesc.java 3ac3245 
  ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java cea9fe2 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/BoundaryDef.java 07590c0 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PTFExpressionDef.java 5d200fb 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PTFInputDef.java 19ed2f2 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PTFQueryInputDef.java 11ef932 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/PartitionedTableFunctionDef.java 327304c 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowExpressionDef.java b96e9d6 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowFrameDef.java 949ed10 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowFunctionDef.java e4ea358 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowTableFunctionDef.java 083aaf2 
  ql/src/test/queries/clientpositive/ptf_matchpath.q 80dbe29 
  ql/src/test/results/clientpositive/correlationoptimizer12.q.out 1333a8a 
  ql/src/test/results/clientpositive/ctas_colname.q.out 4eb827c 
  ql/src/test/results/clientpositive/groupby_grouping_window.q.out c0e6e5f 
  ql/src/test/results/clientpositive/groupby_resolution.q.out e5d22a3 
  ql/src/test/results/clientpositive/ptf.q.out b82defd 
  ql/src/test/results/clientpositive/ptf_matchpath.q.out e0cea0d 
  ql/src/test/results/clientpositive/ptf_streaming.q.out 6552c3a6 
  ql/src/test/results/clientpositive/quotedid_basic.q.out 6c7a017 
  ql/src/test/results/clientpositive/sample10.q.out 6495fb8 
  ql/src/test/results/clientpositive/sample2.q.out 5b6b0f5 
  ql/src/test/results/clientpositive/sample4.q.out b39cc2c 
  ql/src/test/results/clientpositive/sample6.q.out dd8d288 
  ql/src/test/results/clientpositive/sample9.q.out a8c2e82 
  ql/src/test/results/clientpositive/smb_mapjoin_11.q.out 056c9f1 
  ql/src/test/results/clientpositive/spark/ptf.q.out 2e12c1d 
  ql/src/test/results/clientpositive/spark/ptf_matchpath.q.out e0cea0d 
  ql/src/test/results/clientpositive/spark/ptf_streaming.q.out d759fac 
  ql/src/test/results/clientpositive/spark/sample10.q.out b63718b 
  ql/src/test/results/clientpositive/spark/sample2.q.out eac6fb4 
  ql/src/test/results/clientpositive/spark/sample4.q.out 8030f74 
  ql/src/test/results/clientpositive/spark/sample6.q.out 47da933 
  ql/src/test/results/clientpositive/spark/sample9.q.out ff5d08e 
  ql/src/test/results/clientpositive/spark/smb_mapjoin_11.q.out 6881804 
  ql/src/test/results/clientpositive/spark/subquery_in.q.out 53c28c2 
  ql/src/test/results/clientpositive/spark/vectorized_ptf.q.out 5b6242e 
  ql/src/test/results/clientpositive/subquery_in.q.out 3a5e77b 
  ql/src/test/results/clientpositive/subquery_in_having.q.out 1046c9e 
  ql/src/test/results/clientpositive/subquery_notin.q.out 5811394 
  ql/src/test/results/clientpositive/subquery_unqualcolumnrefs.q.out 8c6b202 
  ql/src/test/results/clientpositive/tez/ptf.q.out 3f5f2c6 
  ql/src/test/results/clientpositive/tez/ptf_matchpath.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/tez/ptf_streaming.q.out 79cb92c 
  ql/src/test/results/clientpositive/tez/subquery_in.q.out 69eb568 
  ql/src/test/results/clientpositive/tez/vectorized_ptf.q.out d5d6dc3 
  ql/src/test/results/clientpositive/union_remove_6_subq.q.out be15c1f 
  ql/src/test/results/clientpositive/vectorized_ptf.q.out 6bd98b7 
  ql/src/test/results/clientpositive/windowing_streaming.q.out d45646a 

Diff: https://reviews.apache.org/r/29196/diff/


Testing
-------


Thanks,

Navis Ryu