[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #100: [Improvement] Introduce config to customize assignment server numbers in client side

[GitBox <gi...@apache.org>]

zuston commented on code in PR #100:
URL: https://github.com/apache/incubator-uniffle/pull/100#discussion_r934334919


##########
docs/client_guide.md:
##########
@@ -88,6 +88,7 @@ These configurations are shared by all types of clients.
 |<client_type>.rss.client.send.threadPool.size|5|The thread size for send shuffle data to shuffle server|
 |<client_type>.rss.client.assignment.tags|-|The comma-separated list of tags for deciding assignment shuffle servers. Notice that the SHUFFLE_SERVER_VERSION will always as the assignment tag whether this conf is set or not|
 |<client_type>.rss.client.data.commit.pool.size|The number of assigned shuffle servers|The thread size for sending commit to shuffle servers|
+|<client_type>.rss.client.assignment.shuffle.nodes.max|-1|The number of required assignment shuffle servers. If it is less than 0 or greater than the coordinator's config of "rss.coordinator.shuffle.nodes.max", it will use the size of "rss.coordinator.shuffle.nodes.max" default|

Review Comment:
   If it is less than 0 or equal to 0 or greater than the coordinator's config of "rss.coordinator.shuffle.nodes.max", it will use the size of "rss.coordinator.shuffle.nodes.max" default. 
   
   I missed the condition of ==0.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org