You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@iceberg.apache.org by Ryan Blue <rb...@netflix.com.INVALID> on 2019/02/27 21:11:01 UTC

[VOTE] Community code reviews

This is a follow-up to the discussion thread, where we seem to have
consensus around the proposal to allow committers to commit their own pull
requests if a contributor has reviewed it and given a +1 and the PR has
been open for at least a couple of days to give time for other comments.
This is also only effective for 2019. After that, we should rely on a
larger base of committers.

Please vote on this proposal in the next 3 days.

[ ] +1, accept contributor reviews for committer pull requests
[ ] +0, . . .
[ ] -1, I think this is a bad idea because . . .


rb

-- 
Ryan Blue
Software Engineer
Netflix

Re: [VOTE] Community code reviews

Posted by John Zhuge <jz...@apache.org>.

+1

On Wed, Feb 27, 2019 at 1:11 PM Ryan Blue <rb...@netflix.com.invalid> wrote:

> This is a follow-up to the discussion thread, where we seem to have
> consensus around the proposal to allow committers to commit their own pull
> requests if a contributor has reviewed it and given a +1 and the PR has
> been open for at least a couple of days to give time for other comments.
> This is also only effective for 2019. After that, we should rely on a
> larger base of committers.
>
> Please vote on this proposal in the next 3 days.
>
> [ ] +1, accept contributor reviews for committer pull requests
> [ ] +0, . . .
> [ ] -1, I think this is a bad idea because . . .
>
>
> rb
>
> --
> Ryan Blue
> Software Engineer
> Netflix
>


-- 
John Zhuge

Re: [VOTE] Community code reviews

Posted by Owen O'Malley <ow...@gmail.com>.

+1

> On Feb 28, 2019, at 8:03 AM, Romin Parekh <ro...@gmail.com> wrote:
> 
> +1
> 
> On Thu, Feb 28, 2019 at 1:17 AM Anton Okolnychyi <ao...@apple.com.invalid> wrote:
> +1
> 
>> On 28 Feb 2019, at 07:47, Renato Marroquín Mogrovejo <renatoj.marroquin@gmail.com <ma...@gmail.com>> wrote:
>> 
>> +1
>> 
>> El jue., 28 feb. 2019 a las 8:00, Dongjoon Hyun (<dongjoon@apache.org <ma...@apache.org>>) escribió:
>> +1
>> 
>> On 2019/02/27 21:41:56, RD <rdsr.me@gmail.com <ma...@gmail.com>> wrote: 
>> > +1
>> > 
>> > On Wed, Feb 27, 2019 at 1:40 PM Matt Cheah <mcheah@palantir.com <ma...@palantir.com>> wrote:
>> > 
>> > > +1
>> > >
>> > >
>> > >
>> > > *From: *Ryan Blue <rblue@netflix.com.INVALID <ma...@netflix.com.INVALID>>
>> > > *Reply-To: *"dev@iceberg.apache.org <ma...@iceberg.apache.org>" <dev@iceberg.apache.org <ma...@iceberg.apache.org>>, "
>> > > rblue@netflix.com <ma...@netflix.com>" <rblue@netflix.com <ma...@netflix.com>>
>> > > *Date: *Wednesday, February 27, 2019 at 1:36 PM
>> > > *To: *Iceberg Dev List <dev@iceberg.apache.org <ma...@iceberg.apache.org>>
>> > > *Subject: *Re: [VOTE] Community code reviews
>> > >
>> > >
>> > >
>> > > +1
>> > >
>> > >
>> > >
>> > > On Wed, Feb 27, 2019 at 1:11 PM Ryan Blue <rblue@netflix.com <ma...@netflix.com>> wrote:
>> > >
>> > > This is a follow-up to the discussion thread, where we seem to have
>> > > consensus around the proposal to allow committers to commit their own pull
>> > > requests if a contributor has reviewed it and given a +1 and the PR has
>> > > been open for at least a couple of days to give time for other comments.
>> > > This is also only effective for 2019. After that, we should rely on a
>> > > larger base of committers.
>> > >
>> > >
>> > >
>> > > Please vote on this proposal in the next 3 days.
>> > >
>> > >
>> > >
>> > > [ ] +1, accept contributor reviews for committer pull requests
>> > >
>> > > [ ] +0, . . .
>> > >
>> > > [ ] -1, I think this is a bad idea because . . .
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > rb
>> > >
>> > >
>> > >
>> > > --
>> > >
>> > > Ryan Blue
>> > >
>> > > Software Engineer
>> > >
>> > > Netflix
>> > >
>> > >
>> > >
>> > >
>> > > --
>> > >
>> > > Ryan Blue
>> > >
>> > > Software Engineer
>> > >
>> > > Netflix
>> > >
>> > 
> 
> 
> 
> -- 
> Best,
> Romin Parekh
> 
>

Re: [VOTE] Community code reviews

Posted by Romin Parekh <ro...@gmail.com>.

+1

On Thu, Feb 28, 2019 at 1:17 AM Anton Okolnychyi
<ao...@apple.com.invalid> wrote:

> +1
>
> On 28 Feb 2019, at 07:47, Renato Marroquín Mogrovejo <
> renatoj.marroquin@gmail.com> wrote:
>
> +1
>
> El jue., 28 feb. 2019 a las 8:00, Dongjoon Hyun (<do...@apache.org>)
> escribió:
>
>> +1
>>
>> On 2019/02/27 21:41:56, RD <rd...@gmail.com> wrote:
>> > +1
>> >
>> > On Wed, Feb 27, 2019 at 1:40 PM Matt Cheah <mc...@palantir.com> wrote:
>> >
>> > > +1
>> > >
>> > >
>> > >
>> > > *From: *Ryan Blue <rb...@netflix.com.INVALID>
>> > > *Reply-To: *"dev@iceberg.apache.org" <de...@iceberg.apache.org>, "
>> > > rblue@netflix.com" <rb...@netflix.com>
>> > > *Date: *Wednesday, February 27, 2019 at 1:36 PM
>> > > *To: *Iceberg Dev List <de...@iceberg.apache.org>
>> > > *Subject: *Re: [VOTE] Community code reviews
>> > >
>> > >
>> > >
>> > > +1
>> > >
>> > >
>> > >
>> > > On Wed, Feb 27, 2019 at 1:11 PM Ryan Blue <rb...@netflix.com> wrote:
>> > >
>> > > This is a follow-up to the discussion thread, where we seem to have
>> > > consensus around the proposal to allow committers to commit their own
>> pull
>> > > requests if a contributor has reviewed it and given a +1 and the PR
>> has
>> > > been open for at least a couple of days to give time for other
>> comments.
>> > > This is also only effective for 2019. After that, we should rely on a
>> > > larger base of committers.
>> > >
>> > >
>> > >
>> > > Please vote on this proposal in the next 3 days.
>> > >
>> > >
>> > >
>> > > [ ] +1, accept contributor reviews for committer pull requests
>> > >
>> > > [ ] +0, . . .
>> > >
>> > > [ ] -1, I think this is a bad idea because . . .
>> > >
>> > >
>> > >
>> > >
>> > >
>> > > rb
>> > >
>> > >
>> > >
>> > > --
>> > >
>> > > Ryan Blue
>> > >
>> > > Software Engineer
>> > >
>> > > Netflix
>> > >
>> > >
>> > >
>> > >
>> > > --
>> > >
>> > > Ryan Blue
>> > >
>> > > Software Engineer
>> > >
>> > > Netflix
>> > >
>> >
>>
>
>

-- 
Best,
*Romin Parekh*

Re: [VOTE] Community code reviews

Posted by Anton Okolnychyi <ao...@apple.com.INVALID>.

+1

> On 28 Feb 2019, at 07:47, Renato Marroquín Mogrovejo <re...@gmail.com> wrote:
> 
> +1
> 
> El jue., 28 feb. 2019 a las 8:00, Dongjoon Hyun (<dongjoon@apache.org <ma...@apache.org>>) escribió:
> +1
> 
> On 2019/02/27 21:41:56, RD <rdsr.me@gmail.com <ma...@gmail.com>> wrote: 
> > +1
> > 
> > On Wed, Feb 27, 2019 at 1:40 PM Matt Cheah <mcheah@palantir.com <ma...@palantir.com>> wrote:
> > 
> > > +1
> > >
> > >
> > >
> > > *From: *Ryan Blue <rb...@netflix.com.INVALID>
> > > *Reply-To: *"dev@iceberg.apache.org <ma...@iceberg.apache.org>" <dev@iceberg.apache.org <ma...@iceberg.apache.org>>, "
> > > rblue@netflix.com <ma...@netflix.com>" <rblue@netflix.com <ma...@netflix.com>>
> > > *Date: *Wednesday, February 27, 2019 at 1:36 PM
> > > *To: *Iceberg Dev List <dev@iceberg.apache.org <ma...@iceberg.apache.org>>
> > > *Subject: *Re: [VOTE] Community code reviews
> > >
> > >
> > >
> > > +1
> > >
> > >
> > >
> > > On Wed, Feb 27, 2019 at 1:11 PM Ryan Blue <rblue@netflix.com <ma...@netflix.com>> wrote:
> > >
> > > This is a follow-up to the discussion thread, where we seem to have
> > > consensus around the proposal to allow committers to commit their own pull
> > > requests if a contributor has reviewed it and given a +1 and the PR has
> > > been open for at least a couple of days to give time for other comments.
> > > This is also only effective for 2019. After that, we should rely on a
> > > larger base of committers.
> > >
> > >
> > >
> > > Please vote on this proposal in the next 3 days.
> > >
> > >
> > >
> > > [ ] +1, accept contributor reviews for committer pull requests
> > >
> > > [ ] +0, . . .
> > >
> > > [ ] -1, I think this is a bad idea because . . .
> > >
> > >
> > >
> > >
> > >
> > > rb
> > >
> > >
> > >
> > > --
> > >
> > > Ryan Blue
> > >
> > > Software Engineer
> > >
> > > Netflix
> > >
> > >
> > >
> > >
> > > --
> > >
> > > Ryan Blue
> > >
> > > Software Engineer
> > >
> > > Netflix
> > >
> >

Re: [VOTE] Community code reviews

Posted by Renato Marroquín Mogrovejo <re...@gmail.com>.

+1

El jue., 28 feb. 2019 a las 8:00, Dongjoon Hyun (<do...@apache.org>)
escribió:

> +1
>
> On 2019/02/27 21:41:56, RD <rd...@gmail.com> wrote:
> > +1
> >
> > On Wed, Feb 27, 2019 at 1:40 PM Matt Cheah <mc...@palantir.com> wrote:
> >
> > > +1
> > >
> > >
> > >
> > > *From: *Ryan Blue <rb...@netflix.com.INVALID>
> > > *Reply-To: *"dev@iceberg.apache.org" <de...@iceberg.apache.org>, "
> > > rblue@netflix.com" <rb...@netflix.com>
> > > *Date: *Wednesday, February 27, 2019 at 1:36 PM
> > > *To: *Iceberg Dev List <de...@iceberg.apache.org>
> > > *Subject: *Re: [VOTE] Community code reviews
> > >
> > >
> > >
> > > +1
> > >
> > >
> > >
> > > On Wed, Feb 27, 2019 at 1:11 PM Ryan Blue <rb...@netflix.com> wrote:
> > >
> > > This is a follow-up to the discussion thread, where we seem to have
> > > consensus around the proposal to allow committers to commit their own
> pull
> > > requests if a contributor has reviewed it and given a +1 and the PR has
> > > been open for at least a couple of days to give time for other
> comments.
> > > This is also only effective for 2019. After that, we should rely on a
> > > larger base of committers.
> > >
> > >
> > >
> > > Please vote on this proposal in the next 3 days.
> > >
> > >
> > >
> > > [ ] +1, accept contributor reviews for committer pull requests
> > >
> > > [ ] +0, . . .
> > >
> > > [ ] -1, I think this is a bad idea because . . .
> > >
> > >
> > >
> > >
> > >
> > > rb
> > >
> > >
> > >
> > > --
> > >
> > > Ryan Blue
> > >
> > > Software Engineer
> > >
> > > Netflix
> > >
> > >
> > >
> > >
> > > --
> > >
> > > Ryan Blue
> > >
> > > Software Engineer
> > >
> > > Netflix
> > >
> >
>

Re: [VOTE] Community code reviews

Posted by Dongjoon Hyun <do...@apache.org>.

+1

On 2019/02/27 21:41:56, RD <rd...@gmail.com> wrote: 
> +1
> 
> On Wed, Feb 27, 2019 at 1:40 PM Matt Cheah <mc...@palantir.com> wrote:
> 
> > +1
> >
> >
> >
> > *From: *Ryan Blue <rb...@netflix.com.INVALID>
> > *Reply-To: *"dev@iceberg.apache.org" <de...@iceberg.apache.org>, "
> > rblue@netflix.com" <rb...@netflix.com>
> > *Date: *Wednesday, February 27, 2019 at 1:36 PM
> > *To: *Iceberg Dev List <de...@iceberg.apache.org>
> > *Subject: *Re: [VOTE] Community code reviews
> >
> >
> >
> > +1
> >
> >
> >
> > On Wed, Feb 27, 2019 at 1:11 PM Ryan Blue <rb...@netflix.com> wrote:
> >
> > This is a follow-up to the discussion thread, where we seem to have
> > consensus around the proposal to allow committers to commit their own pull
> > requests if a contributor has reviewed it and given a +1 and the PR has
> > been open for at least a couple of days to give time for other comments.
> > This is also only effective for 2019. After that, we should rely on a
> > larger base of committers.
> >
> >
> >
> > Please vote on this proposal in the next 3 days.
> >
> >
> >
> > [ ] +1, accept contributor reviews for committer pull requests
> >
> > [ ] +0, . . .
> >
> > [ ] -1, I think this is a bad idea because . . .
> >
> >
> >
> >
> >
> > rb
> >
> >
> >
> > --
> >
> > Ryan Blue
> >
> > Software Engineer
> >
> > Netflix
> >
> >
> >
> >
> > --
> >
> > Ryan Blue
> >
> > Software Engineer
> >
> > Netflix
> >
>

Re: [VOTE] Community code reviews

Posted by RD <rd...@gmail.com>.

+1

On Wed, Feb 27, 2019 at 1:40 PM Matt Cheah <mc...@palantir.com> wrote:

> +1
>
>
>
> *From: *Ryan Blue <rb...@netflix.com.INVALID>
> *Reply-To: *"dev@iceberg.apache.org" <de...@iceberg.apache.org>, "
> rblue@netflix.com" <rb...@netflix.com>
> *Date: *Wednesday, February 27, 2019 at 1:36 PM
> *To: *Iceberg Dev List <de...@iceberg.apache.org>
> *Subject: *Re: [VOTE] Community code reviews
>
>
>
> +1
>
>
>
> On Wed, Feb 27, 2019 at 1:11 PM Ryan Blue <rb...@netflix.com> wrote:
>
> This is a follow-up to the discussion thread, where we seem to have
> consensus around the proposal to allow committers to commit their own pull
> requests if a contributor has reviewed it and given a +1 and the PR has
> been open for at least a couple of days to give time for other comments.
> This is also only effective for 2019. After that, we should rely on a
> larger base of committers.
>
>
>
> Please vote on this proposal in the next 3 days.
>
>
>
> [ ] +1, accept contributor reviews for committer pull requests
>
> [ ] +0, . . .
>
> [ ] -1, I think this is a bad idea because . . .
>
>
>
>
>
> rb
>
>
>
> --
>
> Ryan Blue
>
> Software Engineer
>
> Netflix
>
>
>
>
> --
>
> Ryan Blue
>
> Software Engineer
>
> Netflix
>

Re: [VOTE] Community code reviews

Posted by Matt Cheah <mc...@palantir.com>.

+1

From: Ryan Blue <rb...@netflix.com.INVALID>
Reply-To: "dev@iceberg.apache.org" <de...@iceberg.apache.org>, "rblue@netflix.com" <rb...@netflix.com>
Date: Wednesday, February 27, 2019 at 1:36 PM
To: Iceberg Dev List <de...@iceberg.apache.org>
Subject: Re: [VOTE] Community code reviews

+1

On Wed, Feb 27, 2019 at 1:11 PM Ryan Blue <rb...@netflix.com> wrote:

This is a follow-up to the discussion thread, where we seem to have consensus around the proposal to allow committers to commit their own pull requests if a contributor has reviewed it and given a +1 and the PR has been open for at least a couple of days to give time for other comments. This is also only effective for 2019. After that, we should rely on a larger base of committers. 

Please vote on this proposal in the next 3 days.

[ ] +1, accept contributor reviews for committer pull requests

[ ] +0, . . .

[ ] -1, I think this is a bad idea because . . .

rb

-- 

Ryan Blue 

Software Engineer

Netflix

-- 

Ryan Blue 

Software Engineer

Netflix

Re: [VOTE] Community code reviews

Posted by Ryan Blue <rb...@netflix.com.INVALID>.

+1

On Wed, Feb 27, 2019 at 1:11 PM Ryan Blue <rb...@netflix.com> wrote:

> This is a follow-up to the discussion thread, where we seem to have
> consensus around the proposal to allow committers to commit their own pull
> requests if a contributor has reviewed it and given a +1 and the PR has
> been open for at least a couple of days to give time for other comments.
> This is also only effective for 2019. After that, we should rely on a
> larger base of committers.
>
> Please vote on this proposal in the next 3 days.
>
> [ ] +1, accept contributor reviews for committer pull requests
> [ ] +0, . . .
> [ ] -1, I think this is a bad idea because . . .
>
>
> rb
>
> --
> Ryan Blue
> Software Engineer
> Netflix
>


-- 
Ryan Blue
Software Engineer
Netflix