[GitHub] [flink] hlteoh37 commented on a diff in pull request #21590: [FLINK-30550] Flink master to integrate KDS/KDF docs from flink-conne…

[GitBox <gi...@apache.org>]

hlteoh37 commented on code in PR #21590:
URL: https://github.com/apache/flink/pull/21590#discussion_r1060482687


##########
docs/data/sql_connectors.yml:
##########
@@ -169,22 +169,26 @@ upsert-kafka:
 kinesis:
     name: Amazon Kinesis Data Streams
     category: connector
-    maven: flink-connector-kinesis
-    sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kinesis/$version/flink-sql-connector-kinesis-$version.jar
+    versions:
+        - versions: universal

Review Comment:
   Why `universal` here and `4.0.0` below? Is it translated somewhere?



##########
docs/setup_docs.sh:
##########
@@ -63,7 +63,7 @@ mkdir tmp
 cd tmp
 
 integrate_connector_docs elasticsearch v3.0.0
-integrate_connector_docs aws v3.0.0
+integrate_connector_docs aws v4.0

Review Comment:
   v4.0.0? Is the `.0` intentionally left out?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org