You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "explise (via GitHub)" <gi...@apache.org> on 2026/05/06 16:43:16 UTC
[I] feat(go): add diagnostic event subscription to client [iggy]
explise opened a new issue, #3219:
URL: https://github.com/apache/iggy/issues/3219
### Description
## Summary
The Go SDK currently has no way for callers to observe client-level lifecycle events (connection state changes, auth state changes). The Rust SDK exposes these via `Client::subscribe_events()` returning a stream of `DiagnosticEvent`. This issue ports that capability to the Go SDK.
## Motivation
The Go TCP client already has TODO stubs in place for event emission, indicating this was anticipated:
- `foreign/go/client/tcp/tcp_core.go:399` — `// TODO publish event`
- `foreign/go/client/tcp/tcp_core.go:461` — `// TODO event pushing logic`
- `foreign/go/client/tcp/tcp_core.go:475` — `// TODO push shutdown event.
This is groundwork for adding a high-level `IggyConsumer` abstraction to the Go SDK (planned as a follow-up). Diagnostic events let the consumer detect disconnects, re-join consumer groups eagerly on reconnect, and resume cleanly. Beyond the consumer use case, the events are also useful for application-level observability (logging connection drops, exposing health metrics, etc.).
## Scope
In scope:
1. Add a `DiagnosticEvent` type in `foreign/go/contracts/` mirroring the Rust enum (5 variants, with a `String()` method matching the `snake_case` form used in Rust).
2. Add `SubscribeEvents() <-chan DiagnosticEvent` to the `Client` interface in `foreign/go/contracts/client.go`.
3. Implement a small fan-out broadcaster in the TCP client so multiple subscribers can each receive every event independently.
4. Wire emission into the TCP client:
- `Connected` — on initial connect and on every successful auto-reconnect (existing reconnect loop at `foreign/go/client/tcp/tcp_core.go:86-100, 351-401`)
- `Disconnected` — at the existing TODO at `tcp_core.go:399`
- `Shutdown` — at the existing TODO at `tcp_core.go:475`
- `SignedIn` — after successful `LoginUser`
- `SignedOut` — after successful `LogoutUser`
5. Integration test that subscribes, exercises connect → disconnect → reconnect → login → logout → close, and asserts the full event sequence is delivered.
### Component
Go SDK
### Proposed solution
_No response_
### Alternatives considered
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "iYashMaurya (via GitHub)" <gi...@apache.org>.
iYashMaurya commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-6412181114
Thanks, will start working on this issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "explise (via GitHub)" <gi...@apache.org>.
explise commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-4566743057
@hubcio i will pick this up probably next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "iYashMaurya (via GitHub)" <gi...@apache.org>.
iYashMaurya commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-4715403650
Hey @hubcio , It's been while and I haven't seen any progress in the issue so can I pick this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "slbotbm (via GitHub)" <gi...@apache.org>.
slbotbm commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-6381383182
@iYashMaurya since pr author has not responded, you can take this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "iYashMaurya (via GitHub)" <gi...@apache.org>.
iYashMaurya commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-6265584994
Hey @hubcio, this PR has been in draft for over a month. If @explise is unavailable to continue working on it, would it be okay for me to pick it up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "explise (via GitHub)" <gi...@apache.org>.
explise commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-4390179805
@hubcio @chengxilo please assign this to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-4520159805
@explise what's the status? do you need any help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "chengxilo (via GitHub)" <gi...@apache.org>.
chengxilo commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-4643219988
> [@hubcio](https://github.com/hubcio) i will pick this up probably next week.
Hi, any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "raman20 (via GitHub)" <gi...@apache.org>.
raman20 commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-4645605070
/take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "explise (via GitHub)" <gi...@apache.org>.
explise commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-4715416998
@iYashMaurya i have almost finished development here and about to raise a PR, please look into another good first issues. Thanks.
cc: @hubcio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-6265615472
@explise are you planning to finish this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-4648819897
@raman20 no, please read what @explise wrote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "raman20 (via GitHub)" <gi...@apache.org>.
raman20 commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-4645614535
@hubcio hey can i pick this ??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] feat(go): add diagnostic event subscription to client [iggy]
Posted by "chengxilo (via GitHub)" <gi...@apache.org>.
chengxilo commented on issue #3219:
URL: https://github.com/apache/iggy/issues/3219#issuecomment-4394312893
I'm sorry I don't have that privilege, but I believe @hubcio can help u.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org