You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/16 12:43:18 UTC

[GitHub] [incubator-inlong] vernedeng opened a new pull request #3174: [INLONG-3173][Sort-Standalone] Unify SortClusterConfig in manager and sort-standalone

vernedeng opened a new pull request #3174:
URL: https://github.com/apache/incubator-inlong/pull/3174


   ### Title Name: [INLONG-3173][Sort-Standalone] Unify SortClusterConfig in manager and sort-standalone
   
   Fixes #3173 
   
   unify the sturcture
   and
   remove "sinkType" from sink params, which cause initilization failure in Sort-Standalone
   
   ### Motivation
   
   *Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] vernedeng commented on a change in pull request #3174: [INLONG-3173][Sort-Standalone] Unify SortClusterConfig in manager and sort-standalone

Posted by GitBox <gi...@apache.org>.
vernedeng commented on a change in pull request #3174:
URL: https://github.com/apache/incubator-inlong/pull/3174#discussion_r828695649



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sort/SortClusterConfigResponse.java
##########
@@ -43,8 +43,8 @@
     @Builder
     @Data
     public static class SortTaskConfig {
-        String taskName;
-        SinkType sinkType;
+        String name;
+        SinkType type;

Review comment:
       fix in next pr




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] luchunliang commented on a change in pull request #3174: [INLONG-3173][Sort-Standalone] Unify SortClusterConfig in manager and sort-standalone

Posted by GitBox <gi...@apache.org>.
luchunliang commented on a change in pull request #3174:
URL: https://github.com/apache/incubator-inlong/pull/3174#discussion_r828678763



##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sort/SortClusterConfigResponse.java
##########
@@ -31,7 +31,7 @@
     String msg;
     int code;
     String md5;
-    List<SortTaskConfig> tasks;
+    SortClusterConfig data;

Review comment:
       pojo class can move to inlong-common module.
   And remove pojo class of sort-standalone module "org.apache.inlong.sort.standalone.config.pojo".
   Use same class in sort-standalone and manager.

##########
File path: inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sort/SortClusterConfigResponse.java
##########
@@ -43,8 +43,8 @@
     @Builder
     @Data
     public static class SortTaskConfig {
-        String taskName;
-        SinkType sinkType;
+        String name;
+        SinkType type;

Review comment:
       It is better that type is String.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow commented on a change in pull request #3174: [INLONG-3173][Sort-Standalone] Unify SortClusterConfig in manager and sort-standalone

Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #3174:
URL: https://github.com/apache/incubator-inlong/pull/3174#discussion_r828994554



##########
File path: inlong-common/src/main/java/org/apache/inlong/common/pojo/sortstandalone/SortTaskConfig.java
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.common.pojo.sortstandalone;
+
+import lombok.Builder;
+import lombok.Data;
+
+import java.util.List;
+import java.util.Map;
+
+@Data
+@Builder

Review comment:
       Please add `NoArgsConstructor` and `AllArgsConstructor` annotations for the pojo classes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow merged pull request #3174: [INLONG-3173][Sort-Standalone] Unify SortClusterConfig in manager and sort-standalone

Posted by GitBox <gi...@apache.org>.
healchow merged pull request #3174:
URL: https://github.com/apache/incubator-inlong/pull/3174


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] healchow merged pull request #3174: [INLONG-3173][Sort-Standalone] Unify SortClusterConfig in manager and sort-standalone

Posted by GitBox <gi...@apache.org>.
healchow merged pull request #3174:
URL: https://github.com/apache/incubator-inlong/pull/3174


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] vernedeng commented on a change in pull request #3174: [INLONG-3173][Sort-Standalone] Unify SortClusterConfig in manager and sort-standalone

Posted by GitBox <gi...@apache.org>.
vernedeng commented on a change in pull request #3174:
URL: https://github.com/apache/incubator-inlong/pull/3174#discussion_r829010691



##########
File path: inlong-common/src/main/java/org/apache/inlong/common/pojo/sortstandalone/SortTaskConfig.java
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.common.pojo.sortstandalone;
+
+import lombok.Builder;
+import lombok.Data;
+
+import java.util.List;
+import java.util.Map;
+
+@Data
+@Builder

Review comment:
       thx, fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org