You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/02 15:34:00 UTC

[jira] [Commented] (BEAM-2468) Reading Kinesis records in the background

    [ https://issues.apache.org/jira/browse/BEAM-2468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188326#comment-16188326 ] 

ASF GitHub Bot commented on BEAM-2468:
--------------------------------------

GitHub user pawel-kaczmarczyk opened a pull request:

    https://github.com/apache/beam/pull/3930

    [BEAM-2468] Reading Kinesis records in the background

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
     - [X] Each commit in the pull request should have a meaningful subject line and body.
     - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
     - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    This pull request introduces a mechanism for reading Kinesis streams in the background threads.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ocadotechnology/incubator-beam kinesis_background_reading

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3930
    
----
commit 9ce5f2e58a4c94c02caf74af54c0bf028c86d533
Author: Pawel Kaczmarczyk <p....@ocado.com>
Date:   2017-10-02T15:24:11Z

    [BEAM-2468] Reading Kinesis records in the background

----


> Reading Kinesis records in the background
> -----------------------------------------
>
>                 Key: BEAM-2468
>                 URL: https://issues.apache.org/jira/browse/BEAM-2468
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-extensions
>            Reporter: Paweł Kaczmarczyk
>            Assignee: Paweł Kaczmarczyk
>
> Currently Kinesis records are read on demand in a runner's thread. We may instead read the records in a background with separate threads and store time in the buffer which will result in a major performance improvement.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)