You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2020/07/24 16:35:43 UTC

[whimsy] branch master updated: Need ext when committing main doc

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 128a4db  Need ext when committing main doc
128a4db is described below

commit 128a4dbc5d39a28f39a5718949f4068bb0545039
Author: Sebb <se...@apache.org>
AuthorDate: Fri Jul 24 17:35:34 2020 +0100

    Need ext when committing main doc
    
    Also don't assume it's a PDF file
---
 www/secretary/workbench/views/actions/icla2.json.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/secretary/workbench/views/actions/icla2.json.rb b/www/secretary/workbench/views/actions/icla2.json.rb
index da985ca..49bfa65 100644
--- a/www/secretary/workbench/views/actions/icla2.json.rb
+++ b/www/secretary/workbench/views/actions/icla2.json.rb
@@ -13,7 +13,7 @@ message = Mailbox.find(@message)
 person = ASF::Person.find(@id)
 
 # extract file extension
-fileext = File.extname(@selected).downcase if @signature.empty?
+fileext = File.extname(@selected).downcase
 
 # obtain per-user information
 _personalize_email(env.user)
@@ -100,7 +100,7 @@ task "svn commit documents/iclas/#@filename/iclaN#{count}#{fileext}" do
 
     # create/add file(s)
     files = {@selected => "icla#{count}#{fileext}"}
-    files[@signature]  = "icla#{count}pdf.asc" unless @signature.to_s.empty?
+    files[@signature]  = "icla#{count}#{fileext}.asc" unless @signature.to_s.empty?
     message.write_svn(dir, @filename, files)
 
     # Show files to be added