You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/02/27 09:39:30 UTC
[GitHub] [phoenix] stoty opened a new pull request #716: Phoenix 5721 h
base1.3
stoty opened a new pull request #716: Phoenix 5721 h base1.3
URL: https://github.com/apache/phoenix/pull/716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] joshelser commented on a change in pull request #716:
PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #716: PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
URL: https://github.com/apache/phoenix/pull/716#discussion_r386709287
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionCoprocessorEnvironment.java
##########
@@ -40,10 +40,9 @@
* clone the configuration provided by the HBase coprocessor environment before modifying it. So
* this class comes in handy where we have to return our custom config.
*/
-public class DelegateRegionCoprocessorEnvironment implements RegionCoprocessorEnvironment {
+public class DelegateRegionCoprocessorEnvironment extends CompatDelegateRegionCoprocessorEnvironment {
Review comment:
Nit: extra space
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] stoty closed pull request #716: PHOENIX-5721 Unify 4.x
branches (for HBase 1.5, 1.4 as well as 1.3)
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #716: PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
URL: https://github.com/apache/phoenix/pull/716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] stoty commented on issue #716: PHOENIX-5721 Unify 4.x
branches (for HBase 1.5, 1.4 as well as 1.3)
Posted by GitBox <gi...@apache.org>.
stoty commented on issue #716: PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
URL: https://github.com/apache/phoenix/pull/716#issuecomment-593856907
Thanks for the careful review, @joshelser
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] joshelser commented on a change in pull request #716:
PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #716: PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
URL: https://github.com/apache/phoenix/pull/716#discussion_r386710602
##########
File path: phoenix-hbase-compat-1.3.0/src/main/java/org/apache/phoenix/compat/hbase/CompatPhoenixRpcScheduler.java
##########
@@ -0,0 +1,17 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
Review comment:
License header got a little mangled here. Make sure `mvn apache-rat:check` still passes, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] joshelser commented on a change in pull request #716:
PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #716: PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
URL: https://github.com/apache/phoenix/pull/716#discussion_r386709361
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DelegateRegionObserver.java
##########
@@ -676,40 +675,13 @@ public Cell postMutationBeforeWAL(ObserverContext<RegionCoprocessorEnvironment>
public DeleteTracker postInstantiateDeleteTracker(
ObserverContext<RegionCoprocessorEnvironment> ctx, DeleteTracker delTracker)
throws IOException {
- return delegate.postInstantiateDeleteTracker(ctx, delTracker);
+ return delegate.postInstantiateDeleteTracker(ctx, delTracker);
Review comment:
nit: extra space
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] joshelser commented on a change in pull request #716:
PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #716: PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
URL: https://github.com/apache/phoenix/pull/716#discussion_r386711426
##########
File path: phoenix-hbase-compat-1.4.0/src/main/java/org/apache/phoenix/compat/hbase/CompatPhoenixRpcScheduler.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
Review comment:
Header here, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] stoty commented on issue #716: PHOENIX-5721 Unify 4.x
branches (for HBase 1.5, 1.4 as well as 1.3)
Posted by GitBox <gi...@apache.org>.
stoty commented on issue #716: PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
URL: https://github.com/apache/phoenix/pull/716#issuecomment-593859866
I haven't updated the patches in the JIRA, as it seems to be down ATM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [phoenix] joshelser commented on a change in pull request #716:
PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #716: PHOENIX-5721 Unify 4.x branches (for HBase 1.5, 1.4 as well as 1.3)
URL: https://github.com/apache/phoenix/pull/716#discussion_r386711576
##########
File path: phoenix-hbase-compat-1.4.0/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java
##########
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.monitoring;
+
+import java.util.Iterator;
+import java.util.Map;
+import java.util.Map.Entry;
+import org.apache.commons.lang.StringUtils;
+import org.apache.hadoop.hbase.metrics.Counter;
+import org.apache.hadoop.hbase.metrics.Gauge;
+import org.apache.hadoop.hbase.metrics.Histogram;
+import org.apache.hadoop.hbase.metrics.Meter;
+import org.apache.hadoop.hbase.metrics.Metric;
+import org.apache.hadoop.hbase.metrics.MetricRegistry;
+import org.apache.hadoop.hbase.metrics.MetricRegistryInfo;
+import org.apache.hadoop.hbase.metrics.Timer;
+import org.apache.hadoop.metrics2.MetricsCollector;
+import org.apache.hadoop.metrics2.MetricsInfo;
+import org.apache.hadoop.metrics2.MetricsRecordBuilder;
+import org.apache.hadoop.metrics2.MetricsSource;
+import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
+import org.apache.hadoop.metrics2.lib.Interns;
+import org.apache.hadoop.metrics2.lib.MutableHistogram;
+import org.apache.hadoop.metrics2.source.JvmMetrics;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Contents mostly copied from GlobalMetricRegistriesAdapter class from hbase-hadoop2-compat The
+ * adapter attaches HBase's MetricRegistry to Hadoop's DefaultMetricsSystem
+ * Note: This DOES NOThandle dynamic attach/detach of registries
Review comment:
nit: NOT_handle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services