You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2022/01/28 22:55:01 UTC
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18177
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
The get_summary() thrift call is not supported in strict_hs2 mode
on impala-shell. The periodic callback is now disabled.
There is no current test in the framework which tests this since
it involves delaying the time between execution and fetch time.
Delaying the compile doesn't help (pre-execute) and adding a
"select sleep(<x>)" doesn't help either (done at fetch time).
Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
---
M shell/impala_client.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18177/1
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10109/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 06 Feb 2022 05:26:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 11:37:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10076/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 20:02:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7774/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 29 Jan 2022 02:28:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7781/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 19:40:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18177
to look at the new patch set (#4).
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
The get_summary() thrift call is not supported in strict_hs2 mode
on impala-shell. The live_progress and live_summary options are
disabled when the strict_hs2_protocol flag is set.
Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
---
M shell/impala_shell.py
M shell/option_parser.py
M tests/shell/test_shell_interactive.py
3 files changed, 53 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18177/4
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7781/
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 02:07:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7810/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 06 Feb 2022 05:33:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7814/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 04:14:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10110/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 06 Feb 2022 05:44:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18177
to look at the new patch set (#2).
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
The get_summary() thrift call is not supported in strict_hs2 mode
on impala-shell. The live_progress and live_summary options are
disabled when the strict_hs2_protocol flag is set.
Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
---
M shell/impala_shell.py
M shell/option_parser.py
M tests/shell/test_shell_interactive.py
3 files changed, 23 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18177/2
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7774/
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 29 Jan 2022 09:03:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18177/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18177/1//COMMIT_MSG@10
PS1, Line 10: The periodic callback is now disabled.
I would prefer a solution where we would return some warning/error to the users when they use both live progress and hs2_strict instead of disabling this feature silently. The live progress feature is not very useful without returning any live progress info :)
http://gerrit.cloudera.org:8080/#/c/18177/1//COMMIT_MSG@14
PS1, Line 14: Delaying the compile doesn't help (pre-execute) and adding a
: "select sleep(<x>)" doesn't help either (done at fetch time).
I think that there are several ways to add this kind of test - you could add sleep to another part of the query, or probably there is a debug_action that could introduce the sleep at the right place.
Note that this wouldn't be needed if we returned an error as mentioned at line 10.
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 11:52:08 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18177
to look at the new patch set (#5).
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
The get_summary() thrift call is not supported in strict_hs2 mode
on impala-shell. The live_progress and live_summary options are
disabled when the strict_hs2_protocol flag is set.
Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
---
M shell/impala_shell.py
M shell/option_parser.py
M tests/shell/test_shell_interactive.py
3 files changed, 53 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18177/5
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18177/4/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/18177/4/shell/impala_shell.py@245
PS4, Line 245:
flake8: E203 whitespace before ':'
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 06 Feb 2022 05:01:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7810/
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 06 Feb 2022 12:11:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18177
to look at the new patch set (#3).
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
The get_summary() thrift call is not supported in strict_hs2 mode
on impala-shell. The live_progress and live_summary options are
disabled when the strict_hs2_protocol flag is set.
Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
---
M shell/impala_shell.py
M shell/option_parser.py
M tests/shell/test_shell_interactive.py
3 files changed, 29 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/18177/3
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 10:43:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
The get_summary() thrift call is not supported in strict_hs2 mode
on impala-shell. The live_progress and live_summary options are
disabled when the strict_hs2_protocol flag is set.
Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Reviewed-on: http://gerrit.cloudera.org:8080/18177
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M shell/impala_shell.py
M shell/option_parser.py
M tests/shell/test_shell_interactive.py
3 files changed, 53 insertions(+), 10 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Csaba Ringhofer: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18177/3/shell/impala_shell.py
File shell/impala_shell.py:
http://gerrit.cloudera.org:8080/#/c/18177/3/shell/impala_shell.py@234
PS3, Line 234: # live_summary and live_progress are turned off in strict_hs2_protocol mode
: if options.live_summary and options.strict_hs2_protocol:
: warning = "WARNING: Unable to track live summary with strict_hs2_protocol"
: print(warning, file=sys.stderr)
: self.live_summary = options.live_summary and not options.strict_hs2_protocol
: if options.live_progress and options.strict_hs2_protocol:
: warning = "WARNING: Unable to track live progress with strict_hs2_protocol"
: print(warning, file=sys.stderr)
This has only effect if we start Impala with live_summery turned on - but it is also possible to change it with SET command, see https://github.com/apache/impala/blob/b28da054f3595bb92873433211438306fc22fbc7/tests/custom_cluster/test_shell_interactive.py#L50
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 21:14:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10082/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 18:18:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11096: Strict hs2 mode in impala-shell does not support get summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18177 )
Change subject: IMPALA-11096: Strict_hs2 mode in impala-shell does not support get_summary
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10067/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aee838a80b4659a13a0a0cb9eabffa2c8767c8f
Gerrit-Change-Number: 18177
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jan 2022 23:18:39 +0000
Gerrit-HasComments: No