[GitHub] [flink] HuangZhenQiu commented on a diff in pull request #20875: [FLINK-29363][runtime-web] allow fully redirection in web dashboard

[GitBox <gi...@apache.org>]

HuangZhenQiu commented on code in PR #20875:
URL: https://github.com/apache/flink/pull/20875#discussion_r976801184


##########
flink-runtime-web/web-dashboard/src/app/app.interceptor.ts:
##########
@@ -39,6 +46,16 @@ export class AppInterceptor implements HttpInterceptor {
 
     return next.handle(req.clone({ withCredentials: true })).pipe(
       catchError(res => {
+        if (
+          res instanceof HttpResponseBase &&
+          (res.status == HttpStatusCode.MovedPermanently ||
+            res.status == HttpStatusCode.TemporaryRedirect ||
+            res.status == HttpStatusCode.SeeOther) &&

Review Comment:
   The code path is mainly to fetching job metadata. Multiple Choices, Use Proxy, Unused are not fit for the scenarios or data type. But I am open to add more status code to make it more robust.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org