[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #877: Remove leftover deprecated variables and methods

[GitBox <gi...@apache.org>]

stevedlawrence commented on code in PR #877:
URL: https://github.com/apache/daffodil/pull/877#discussion_r1026775674


##########
daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala:
##########
@@ -144,14 +130,6 @@ class InvalidParserException(msg: String, cause: Throwable = null) extends Excep
 
 class Compiler private (var validateDFDLSchemas: Boolean,
   var tunables : DaffodilTunables,

Review Comment:
   Can we remove the `var`s here too?



##########
daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala:
##########
@@ -64,16 +63,6 @@ object BothParserAndUnparser extends ParserOrUnparser
 
 final class ProcessorFactory private(
   private var optRootSpec: Option[RootSpec],

Review Comment:
   Can we remove this `var`, similar to what we did with the `DataProcessor`?



##########
daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala:
##########
@@ -144,14 +130,6 @@ class InvalidParserException(msg: String, cause: Throwable = null) extends Excep
 
 class Compiler private (var validateDFDLSchemas: Boolean,
   var tunables : DaffodilTunables,
-  /*
-   * Supports deprecated feature of establishing external vars on the compiler object.
-   * These are just saved and passed to the processor factory which incorporates them into
-   * the variable map of the data processor.
-   *
-   * This argument can be removed once this deprecated feature is removed.
-   */
-  private var externalDFDLVariables: Queue[Binding],

Review Comment:
   Right below this are three private `var`'s that I think can also become `val`s?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org