[GitHub] nswamy commented on a change in pull request #11401: [MXNET-531] Custom Operator Example for Scala

[GitBox <gi...@apache.org>]

nswamy commented on a change in pull request #11401: [MXNET-531] Custom Operator Example for Scala
URL: https://github.com/apache/incubator-mxnet/pull/11401#discussion_r199138200
 
 

 ##########
 File path: scala-package/core/src/main/scala/org/apache/mxnet/SymbolAPI.scala
 ##########
 @@ -16,11 +16,19 @@
  */
 package org.apache.mxnet
 
+import scala.collection.mutable
+
 
 @AddSymbolAPIs(false)
 /**
   * typesafe Symbol API: Symbol.api._
   * Main code will be generated during compile time through Macros
   */
 object SymbolAPI extends SymbolAPIBase {
+  def Custom (op_type : String, kwargs : mutable.Map[String, Any],
+             name : String = null, attr : Map[String, String] = null) : Symbol = {
 
 Review comment:
   should your Custom Op also take optional Seq() for positional arguments?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services