You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/12/21 21:41:57 UTC

[GitHub] tysonnorris commented on a change in pull request #2984: Dynamic LoadBalancer load using SpiLoader

tysonnorris commented on a change in pull request #2984: Dynamic LoadBalancer load using SpiLoader
URL: https://github.com/apache/incubator-openwhisk/pull/2984#discussion_r158384953
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
 ##########
 @@ -339,7 +342,23 @@ class LoadBalancerService(config: WhiskConfig, instance: InstanceId, entityStore
   }
 }
 
-object LoadBalancerService {
+/**
+ * An Spi for providing LoadBalancerService implementations
+ */
+trait LoadBalancerProvider extends Spi {
+  def requiredProperties: Map[String, String]
+
+  def loadBalancer(whiskConfig: WhiskConfig, instance: InstanceId, entityStore: EntityStore)(
 
 Review comment:
   I don't think `entityStore` should be part of this interface, it is an impl detail of the invokerpool, afaik.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services